Deprecate site methods which could be replaced by logevents
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Xqt
	Jun 19 2017, 8:38 PM

Description

There are some methods which are calling logevents by only setting logtype but on the other hand only return a small set of information restricted by a tuple or list. methods should not return tuples/lists/dicts if they could return a LogEntry instance.

See: https://gerrit.wikimedia.org/r/#/c/231859/1/pywikibot/site.py@5467

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	[cleanup] Remove APISite.newfiles method, deprecated for 5 years	pywikibot/core	master	+0 -42
	deprecate site.newfiles() method	pywikibot/core	master	+7 -5

Customize query in gerrit

Event Timeline

Xqt created this task.Jun 19 2017, 8:38 PM

Restricted Application added subscribers: pywikibot-bugs-list, Aklapper. · View Herald TranscriptJun 19 2017, 8:38 PM

Xqt triaged this task as Low priority.Jun 19 2017, 8:38 PM

Xqt claimed this task.Jun 19 2017, 8:49 PM

Change 360090 had a related patch set uploaded (by Xqt; owner: Xqt):
[pywikibot/core@master] deprecate site.newfiles() method

https://gerrit.wikimedia.org/r/360090

gerritbot added a project: Patch-For-Review.Jun 19 2017, 9:20 PM

Change 360090 merged by jenkins-bot:
[pywikibot/core@master] deprecate site.newfiles() method

https://gerrit.wikimedia.org/r/360090

Xqt closed this task as Resolved.Jun 20 2017, 8:15 PM

Change 751944 had a related patch set uploaded (by Xqt; author: Xqt):

[pywikibot/core@master] [cleanup] Remove APISite.newfiles method, deprecated for 5 years

https://gerrit.wikimedia.org/r/751944

Change 751944 merged by jenkins-bot: