Page MenuHomePhabricator
Create Task
Maniphest T168352

ParenthesesAroundKeywordSniff doesn't handle nested parenthesis correctly
Closed, ResolvedPublic
Actions

Description

See https://gerrit.wikimedia.org/r/#/c/360147/1/maintenance/removeOrphanedEvents.php

Patch coming momentarily

Details

SubjectRepoBranchLines +/-
Fix handling of nested parenthesis in ParenthesesAroundKeywordSniffmediawiki/tools/codesniffermaster+22 -7
Customize query in gerrit

Event Timeline

Legoktm created this task.Jun 20 2017, 3:16 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 20 2017, 3:16 AM
gerritbot subscribed.Jun 20 2017, 3:20 AM

Change 360164 had a related patch set uploaded (by Legoktm; owner: Legoktm):
[mediawiki/tools/codesniffer@master] Fix handling of nested parenthesis in ParenthesesAroundKeywordSniff

https://gerrit.wikimedia.org/r/360164

gerritbot added a project: Patch-For-Review.Jun 20 2017, 3:20 AM
Legoktm moved this task from Untriaged to Accepted rule changes on the MediaWiki-Codesniffer board.Jun 20 2017, 3:26 AM
Jdforrester-WMF closed this task as Resolved.Jun 20 2017, 2:42 PM
gerritbot added a comment.Jun 20 2017, 2:47 PM

Change 360164 merged by jenkins-bot:
[mediawiki/tools/codesniffer@master] Fix handling of nested parenthesis in ParenthesesAroundKeywordSniff

https://gerrit.wikimedia.org/r/360164

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL