Description

ukwiki (wmf.19]

Screen Shot 2017-09-19 at 3.14.37 PM.png (542×432 px, 68 KB)

The issue was present in betalabs and wmf.5 for German and Russian.

Screen Shot 2017-06-20 at 7.35.21 PM.png (634×531 px, 94 KB)

Screen Shot 2017-06-20 at 7.36.03 PM.png (590×483 px, 72 KB)

plwiki (wmf.11)

Screen Shot 2017-08-03 at 2.21.39 PM.png (612×678 px, 129 KB)

Dutch wiki does fit the phrasing but could use some improvements.

Screen Shot 2017-06-20 at 7.37.49 PM.png (547×433 px, 58 KB)

Details

	Subject	Repo	Branch	Lines +/-
	Fix invite guided tour overflows	mediawiki/extensions/WikimediaMessages	master	+21 -13

Customize query in gerrit

Related Objects

Mentioned In: T169110: For some languages (here French), the label to save a set of filters is not aligned with the icons

Event Timeline

Etonkovidova created this task.Jun 20 2017, 3:50 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 20 2017, 3:50 PM

It took me a while to spot this: the buttons overflow out of the dialog because of how long the translations are.

Etonkovidova mentioned this in T169110: For some languages (here French), the label to save a set of filters is not aligned with the icons.Jun 28 2017, 9:41 PM

Catrope edited projects, added Collaboration-Team-Triage (Collab-Team-This-Quarter); removed Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017).Jul 18 2017, 5:34 PM

Catrope moved this task from Untriaged to Ready for Pickup on the Collaboration-Team-Triage (Collab-Team-This-Quarter) board.

Etonkovidova updated the task description. (Show Details)Aug 3 2017, 9:22 PM

Etonkovidova renamed this task from [wmf.5] The invite opt-in popup does not accommodate some languages to [wmf.19] The invite opt-in popup does not accommodate some languages .Sep 25 2017, 8:41 PM

Etonkovidova edited projects, added Collaboration-Team-Triage; removed Collaboration-Team-Triage (Collab-Team-This-Quarter).

Etonkovidova updated the task description. (Show Details)

Restricted Application added a subscriber: Base. · View Herald TranscriptSep 25 2017, 8:41 PM

! In T168413#3380989, @Catrope wrote:

It took me a while to spot this: the buttons overflow out of the dialog because of how long the translations are.

Yes. That appears to be correct. Is there a reason the box has to be a fixed height? Is it easy to fix this?

@Mattflaschen-WMF says we manually set the width and height of the popup with width: NNNpx !important. He says the width should be passed in in JS, and we should avoid specifying the height.

• jmatazzoni edited projects, added Collaboration-Team-Triage (Collab-Team-Next-Quarter); removed Collaboration-Team-Triage.Oct 25 2017, 6:51 AM

• jmatazzoni moved this task from Untriaged to Ready for Pickup on the Collaboration-Team-Triage (Collab-Team-Next-Quarter) board.

• Petar.petkovic claimed this task.Oct 31 2017, 6:07 PM

Change 387630 had a related patch set uploaded (by Petar.petkovic; owner: Petar.petkovic):
[mediawiki/extensions/WikimediaMessages@master] Fix invite guided tour overflows

https://gerrit.wikimedia.org/r/387630

gerritbot added a project: Patch-For-Review.Oct 31 2017, 6:17 PM

• Petar.petkovic moved this task from Ready for Pickup to Needs Review on the Collaboration-Team-Triage (Collab-Team-Next-Quarter) board.Oct 31 2017, 6:17 PM

SBisson moved this task from Needs Review to QA Review on the Collaboration-Team-Triage (Collab-Team-Next-Quarter) board.Nov 1 2017, 10:54 AM

Change 387630 merged by jenkins-bot:
[mediawiki/extensions/WikimediaMessages@master] Fix invite guided tour overflows

https://gerrit.wikimedia.org/r/387630

ReleaseTaggerBot added a project: MW-1.31-release-notes (WMF-deploy-2017-11-07 (1.31.0-wmf.7)).Nov 1 2017, 11:00 AM

Checked the fix in betalabs

Screen Shot 2017-11-02 at 5.05.29 PM.png (573×430 px, 64 KB)

Etonkovidova closed this task as Resolved.Nov 3 2017, 12:09 AM

	F10579157: Screen Shot 2017-11-02 at 5.05.29 PM.png
	Nov 3 2017, 12:09 AM

	F9805167: Screen Shot 2017-09-19 at 3.14.37 PM.png
	Sep 25 2017, 8:41 PM

	F8942968: Screen Shot 2017-08-03 at 2.21.39 PM.png
	Aug 3 2017, 9:22 PM

	F8490482: Screen Shot 2017-06-20 at 7.35.21 PM.png
	Jun 20 2017, 3:50 PM

	F8490483: Screen Shot 2017-06-20 at 7.36.03 PM.png
	Jun 20 2017, 3:50 PM

	F8490488: Screen Shot 2017-06-20 at 7.37.49 PM.png
	Jun 20 2017, 3:50 PM

[wmf.19] The invite opt-in popup does not accommodate some languages Closed, ResolvedPublicActions

Description

Details

Related Objects

Event Timeline

[wmf.19] The invite opt-in popup does not accommodate some languages
Closed, ResolvedPublic
Actions