Page MenuHomePhabricator

Support multiline placeholders in VE surface widget
Closed, ResolvedPublic1 Story Points

Description

We added a fairly long message to the basic cite dialog: https://gerrit.wikimedia.org/r/#/c/355447/2. I imagine in other languages this may exceed the line length, at which point the placeholder will just truncate.

Event Timeline

Esanders created this task.Jun 20 2017, 6:32 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 20 2017, 6:32 PM
Deskana triaged this task as Low priority.Jun 20 2017, 7:06 PM
Deskana added a project: Design.
Deskana added a subscriber: Deskana.

In principle this is simple, but it creates a lot of issues for mobile; if a message is super long, and it's not truncated, it could take up the entire screen. Needs a lot of thought.

Deskana moved this task from To Triage to Freezer on the VisualEditor board.Jun 20 2017, 7:30 PM

The use case here is a message that might spill onto 2 lines on desktop. We have quite a few issues with message lengths on mobile which can be addressed on a case by case basis, but the widget shouldn't fail with a long placeholder, and should behave like <textarea>.

Change 360578 had a related patch set uploaded (by Esanders; owner: Esanders):
[VisualEditor/VisualEditor@master] Allow multi-line placeholders on ui.Surface's

https://gerrit.wikimedia.org/r/360578

Jdforrester-WMF set the point value for this task to 1.Jun 20 2017, 10:57 PM
Jdforrester-WMF moved this task from Freezer to TR1: Releases on the VisualEditor board.
Jdforrester-WMF added a subscriber: Jdforrester-WMF.

Ha, well, that quick-and-dirty approach works too. :-)

Jdforrester-WMF closed this task as Resolved.Jun 20 2017, 10:57 PM
Jdforrester-WMF claimed this task.
Restricted Application added a project: User-Ryasmeen. · View Herald TranscriptJun 20 2017, 10:57 PM

Change 360578 merged by jenkins-bot:
[VisualEditor/VisualEditor@master] Allow multi-line placeholders on ui.Surface's

https://gerrit.wikimedia.org/r/360578

Change 360583 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (a25e5de67)

https://gerrit.wikimedia.org/r/360583

Change 360583 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (a25e5de67)

https://gerrit.wikimedia.org/r/360583