Page MenuHomePhabricator

When querying for multiple tags, and more than one is in the edit, duplicate results
Closed, ResolvedPublic

Description

E.g. if the edit is tagged with both foo and bar, and you query for tags foo or bar, the edit will show twice.

Details

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 21 2017, 7:18 AM

For testing after the fix:

  • One tag is selected - 'Mobile web edits'

  • two tags are selected - 'Mobile web edits' and'Mobile edit'. Notice how entires become displayed twice.

Change 364251 had a related patch set uploaded (by Catrope; owner: Catrope):
[mediawiki/core@master] [WIP] RCFilters: Filter duplicates when filtering for multiple tags

https://gerrit.wikimedia.org/r/364251

Change 364251 merged by jenkins-bot:
[mediawiki/core@master] RCFilters: Filter duplicates when filtering for multiple tags

https://gerrit.wikimedia.org/r/364251

Checked the fix in betalabs.

Change 368214 had a related patch set uploaded (by Catrope; owner: Catrope):
[mediawiki/core@wmf/1.30.0-wmf.11] RCFilters: Filter duplicates when filtering for multiple tags

https://gerrit.wikimedia.org/r/368214

Change 368214 merged by jenkins-bot:
[mediawiki/core@wmf/1.30.0-wmf.11] RCFilters: Filter duplicates when filtering for multiple tags

https://gerrit.wikimedia.org/r/368214

Mentioned in SAL (#wikimedia-operations) [2017-07-27T18:29:27Z] <catrope@tin> Synchronized php-1.30.0-wmf.11/includes/: T168501 and T163380 (duration: 01m 31s)

Mentioned in SAL (#wikimedia-operations) [2017-07-27T18:44:15Z] <catrope@tin> Synchronized php-1.30.0-wmf.11/includes/: Temporarily revert patch for T168501 while I fix it (duration: 01m 27s)

Mentioned in SAL (#wikimedia-operations) [2017-07-27T19:05:54Z] <catrope@tin> Synchronized php-1.30.0-wmf.11/includes/: T168501, take two (duration: 01m 27s)