Page MenuHomePhabricator
Create Task
Maniphest T168501

When querying for multiple tags, and more than one is in the edit, duplicate results
Closed, ResolvedPublic
Actions

Assigned To
Catrope
Authored By
• Mattflaschen-WMF
Jun 21 2017, 7:18 AM
Tags
Referenced Files
F8626179: Screen Shot 2017-07-05 at 2.07.59 PM.png
Jul 5 2017, 9:08 PM
F8626173: Screen Shot 2017-07-05 at 2.04.50 PM.png
Jul 5 2017, 9:08 PM
Subscribers
Aklapper
Etonkovidova
gerritbot
• Mattflaschen-WMF
Stashbot

Description

E.g. if the edit is tagged with both foo and bar, and you query for tags foo or bar, the edit will show twice.

Details

ProjectBranchLines +/-Subject
mediawiki/corewmf/1.30.0-wmf.11+51 -15RCFilters: Filter duplicates when filtering for multiple tags
mediawiki/coremaster+51 -15RCFilters: Filter duplicates when filtering for multiple tags
Customize query in gerrit

Related Objects
Search...

View Standalone Graph
This task is connected to more than 200 other tasks. Only direct parents and subtasks are shown here. Use View Standalone Graph to show more of the graph.
StatusSubtypeAssignedTask
· · ·
ResolvedMooeypooT166914 Implement 'Tagged edits' filters and filter menu in the new UI
ResolvedSBissonT164133 Support multiple values for the tagfilter parameter in the ChangesList backend
ResolvedCatropeT168501 When querying for multiple tags, and more than one is in the edit, duplicate results
· · ·

Event Timeline

• Mattflaschen-WMF created this task.Jun 21 2017, 7:18 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 21 2017, 7:18 AM
• Mattflaschen-WMF added a parent task: T164133: Support multiple values for the tagfilter parameter in the ChangesList backend.Jul 5 2017, 7:53 PM
• Mattflaschen-WMF added a parent task: T166914: Implement 'Tagged edits' filters and filter menu in the new UI.
• Mattflaschen-WMF mentioned this in T166914: Implement 'Tagged edits' filters and filter menu in the new UI.
Etonkovidova added a subscriber: Etonkovidova.Jul 5 2017, 9:08 PM

For testing after the fix:

  • One tag is selected - 'Mobile web edits'

Screen Shot 2017-07-05 at 2.04.50 PM.png (393×1 px, 116 KB)

  • two tags are selected - 'Mobile web edits' and'Mobile edit'. Notice how entires become displayed twice.

Screen Shot 2017-07-05 at 2.07.59 PM.png (517×1 px, 193 KB)

• Mattflaschen-WMF mentioned this in T158572: Explore how to make a category search that includes sub-categories. .Jul 8 2017, 1:05 AM
Catrope claimed this task.Jul 10 2017, 5:14 PM
Catrope moved this task from Untriaged to In Development on the Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017) board.
gerritbot added a subscriber: gerritbot.Jul 10 2017, 5:17 PM

Change 364251 had a related patch set uploaded (by Catrope; owner: Catrope):
[mediawiki/core@master] [WIP] RCFilters: Filter duplicates when filtering for multiple tags

https://gerrit.wikimedia.org/r/364251

gerritbot added a project: Patch-For-Review.Jul 10 2017, 5:17 PM
• jmatazzoni mentioned this in T170501: Graduate 'New filters for edit review' out of beta, making it standard on all wikis.Jul 12 2017, 10:53 PM
• jmatazzoni edited projects, added Collaboration-Team-Triage (Collab-Team-This-Quarter); removed Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017).Jul 14 2017, 12:15 AM
• jmatazzoni moved this task from Untriaged to In Development on the Collaboration-Team-Triage (Collab-Team-This-Quarter) board.
Catrope moved this task from In Development to Needs Review on the Collaboration-Team-Triage (Collab-Team-This-Quarter) board.Jul 15 2017, 2:59 AM
• Mattflaschen-WMF moved this task from Needs Review to QA Review on the Collaboration-Team-Triage (Collab-Team-This-Quarter) board.Jul 26 2017, 12:03 AM
gerritbot added a comment.Jul 26 2017, 12:07 AM

Change 364251 merged by jenkins-bot:
[mediawiki/core@master] RCFilters: Filter duplicates when filtering for multiple tags

https://gerrit.wikimedia.org/r/364251

ReleaseTaggerBot added a project: MW-1.30-release-notes (WMF-deploy-2017-08-01_(1.30.0-wmf.12)).Jul 26 2017, 1:01 AM
Etonkovidova added a comment.Jul 27 2017, 12:30 AM

Checked the fix in betalabs.

Etonkovidova closed this task as Resolved.Jul 27 2017, 12:30 AM
Etonkovidova moved this task from QA Review to Product Review on the Collaboration-Team-Triage (Collab-Team-This-Quarter) board.
gerritbot added a comment.Jul 27 2017, 5:19 PM

Change 368214 had a related patch set uploaded (by Catrope; owner: Catrope):
[mediawiki/core@wmf/1.30.0-wmf.11] RCFilters: Filter duplicates when filtering for multiple tags

https://gerrit.wikimedia.org/r/368214

gerritbot added a comment.Jul 27 2017, 6:16 PM

Change 368214 merged by jenkins-bot:
[mediawiki/core@wmf/1.30.0-wmf.11] RCFilters: Filter duplicates when filtering for multiple tags

https://gerrit.wikimedia.org/r/368214

Stashbot added a subscriber: Stashbot.Jul 27 2017, 6:29 PM

Mentioned in SAL (#wikimedia-operations) [2017-07-27T18:29:27Z] <catrope@tin> Synchronized php-1.30.0-wmf.11/includes/: T168501 and T163380 (duration: 01m 31s)

Stashbot mentioned this in T163380: Support posting Jobs to EventBus simultaneously with normal job processing.Jul 27 2017, 6:29 PM
Stashbot added a comment.Jul 27 2017, 6:44 PM

Mentioned in SAL (#wikimedia-operations) [2017-07-27T18:44:15Z] <catrope@tin> Synchronized php-1.30.0-wmf.11/includes/: Temporarily revert patch for T168501 while I fix it (duration: 01m 27s)

ReleaseTaggerBot edited projects, added MW-1.30-release-notes (WMF-deploy-2017-07-25_(1.30.0-wmf.11)); removed MW-1.30-release-notes (WMF-deploy-2017-08-01_(1.30.0-wmf.12)).Jul 27 2017, 7:00 PM
Stashbot added a comment.Jul 27 2017, 7:05 PM

Mentioned in SAL (#wikimedia-operations) [2017-07-27T19:05:54Z] <catrope@tin> Synchronized php-1.30.0-wmf.11/includes/: T168501, take two (duration: 01m 27s)

Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL