Page MenuHomePhabricator

revertbot.py doesn't respect put_throttle parameter in user-config.py
Open, Needs TriagePublic

Description

Steps to reproduce

  1. Change put_throttle in user-config.py to 5
  2. Do the following steps without longer time break, ideally immediately one right after another, but not overlapping
  3. Run any script on some pages (e.g. basic.py)
  4. Run revertbot.py without any parameters
  5. Run any script on some pages (e.g. basic.py)

Expected behavior
Sleeping for # seconds should be similar for script and revertbot

Current behavior
basic.py: Sleeping for 3–5 seconds
revertbot.py: Sleeping for 8–10 seconds
basic.py: Sleeping for 3–5 seconds

A server response should be similar (per step 2), therefore it seems to me as if revertbot.py doesn't respect put_throttle parameter in user-config.py

Environment
last commit of pwb core from master branch, python 3.6.1

TODO

  • Examine what is the result when adding put_throttle as a parameter -pt:5
  • Examine whether it is reproducible on different Wikipedias

Event Timeline

You mean user-config.py I guess.

I couldn't reproduce this.

Is revertbot.py the only script running?
Could you check both scripts with different sites (via -lang option parameter)
Could you set -put_throttle option as parameter and check the behaviour

Dvorapa renamed this task from revertbot.py doesn't respect put_throttle parameter in user-fixes.py to revertbot.py doesn't respect put_throttle parameter in user-config.py.Jun 22 2017, 7:26 AM
Dvorapa updated the task description. (Show Details)

Yes, it is the only script running. I've tried to reproduce this on testwiki, but bot got stuck in an infinite loop somehow:

Snímek z 2017-06-22 09-38-03.png (741×1 px, 296 KB)

That's weird both on test and test2 wikis revertbot is stuck in an infinite loop if running it with lang and user parameters:
python pwb.py revertbot -lang:"test" -user:"DvorapaBot"

Dvorapa updated the task description. (Show Details)
Dvorapa updated the task description. (Show Details)

@Dvorapa: is your problem still occurring with the last patch of revertbot?

@Xqt I can not reproduce this because bot skips 50% of edited pages by callback. What does that mean? Why bot can not revert all his edits?

Snímek z 2017-07-01 11-36-38.png (462×734 px, 51 KB)

Maybe similar issue like in T135304 (T166515)?

Btw when Ctrl + C, following error is thrown:

Snímek z 2017-07-01 11-49-39.png (462×734 px, 61 KB)

(The second traceback is KeyboardInterrupt)