Page MenuHomePhabricator

Errorhandling for invalid json is broken
Closed, ResolvedPublic1 Story Points

Description

It seems that the error dialog that should deal with invalid json in mw.TemplateData.Target.prototype.onEditOpenDialogButton() is no longer functioning.

The failure is reached, but the messagedialog that is intended to be presented doesn't become visible.

See https://en.wikipedia.org/w/index.php?title=Template:Multiple_issues/doc&oldid=782617530&action=edit

Event Timeline

TheDJ created this task.Jun 21 2017, 11:52 AM
Restricted Application added a project: VisualEditor. · View Herald TranscriptJun 21 2017, 11:52 AM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Must be the OOUI dialog regression again.

Change 360682 had a related patch set uploaded (by Esanders; owner: Esanders):
[mediawiki/extensions/TemplateData@master] Use correct name for message dialog

https://gerrit.wikimedia.org/r/360682

Jdforrester-WMF closed this task as Resolved.Jun 21 2017, 6:06 PM
Jdforrester-WMF assigned this task to Esanders.
Jdforrester-WMF triaged this task as High priority.
Jdforrester-WMF set the point value for this task to 1.
Jdforrester-WMF moved this task from To Triage to TR0: Interrupt on the VisualEditor board.
Jdforrester-WMF edited projects, added Editing-team; removed Patch-For-Review.
Restricted Application added a project: User-Ryasmeen. · View Herald TranscriptJun 21 2017, 6:06 PM

Change 360682 merged by jenkins-bot:
[mediawiki/extensions/TemplateData@master] Use correct name for message dialog

https://gerrit.wikimedia.org/r/360682