Page MenuHomePhabricator
Create Task
Maniphest T168521

Errorhandling for invalid json is broken
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

It seems that the error dialog that should deal with invalid json in mw.TemplateData.Target.prototype.onEditOpenDialogButton() is no longer functioning.

The failure is reached, but the messagedialog that is intended to be presented doesn't become visible.

See https://en.wikipedia.org/w/index.php?title=Template:Multiple_issues/doc&oldid=782617530&action=edit

Details

SubjectRepoBranchLines +/-
Use correct name for message dialogmediawiki/extensions/TemplateDatamaster+2 -2
Customize query in gerrit

Event Timeline

TheDJ created this task.Jun 21 2017, 11:52 AM
Restricted Application added a project: VisualEditor. · View Herald TranscriptJun 21 2017, 11:52 AM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Esanders subscribed.Jun 21 2017, 5:48 PM

Must be the OOUI dialog regression again.

gerritbot subscribed.Jun 21 2017, 5:58 PM

Change 360682 had a related patch set uploaded (by Esanders; owner: Esanders):
[mediawiki/extensions/TemplateData@master] Use correct name for message dialog

https://gerrit.wikimedia.org/r/360682

gerritbot added a project: Patch-For-Review.Jun 21 2017, 5:58 PM
Jdforrester-WMF closed this task as Resolved.Jun 21 2017, 6:06 PM
Jdforrester-WMF assigned this task to Esanders.
Jdforrester-WMF triaged this task as High priority.
Jdforrester-WMF set the point value for this task to 1.
Jdforrester-WMF moved this task from To Triage to TR0: Interrupt on the VisualEditor board.
Jdforrester-WMF edited projects, added Editing-team; removed Patch-For-Review.
Restricted Application added a project: User-Ryasmeen. · View Herald TranscriptJun 21 2017, 6:06 PM
gerritbot added a comment.Jun 21 2017, 6:07 PM

Change 360682 merged by jenkins-bot:
[mediawiki/extensions/TemplateData@master] Use correct name for message dialog

https://gerrit.wikimedia.org/r/360682

ReleaseTaggerBot added a project: MW-1.30-release-notes (WMF-deploy-2017-06-27_(1.30.0-wmf.7)).Jun 21 2017, 8:00 PM
TheDJ awarded a token.Jun 22 2017, 12:10 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL