Page MenuHomePhabricator
Create Task
Maniphest T168523

Language codes din and smj are listed in multiple files
Closed, ResolvedPublic
Actions

Description

This is probably very minor, but according to https://phabricator.wikimedia.org/source/mediawiki/browse/master/languages/data/Names.php, https://github.com/wikimedia/operations-mediawiki-config/blob/master/wmf-config/InitialiseSettings.php#L17369 and https://github.com/wikimedia/mediawiki-extensions-Wikibase/blob/master/repo/includes/WikibaseRepo.php#L1803, din and smj are listed in multiple places when they shouldn't need to be.

din has been added to Names.php now, so it's probably redundant to list it as an extra language in wmgExtraLanguageNames.

smj is in wmgExtraLanguageNames, so it doesn't also need to be in getMonolingualTextLanguages.

Details

ProjectBranchLines +/-Subject
operations/mediawiki-configmaster+0 -1Remove 'din' from wmgExtraLanguageNames
mediawiki/extensions/Wikibasemaster+1 -1Remove 'smj' from getMonolingualTextLanguages
Customize query in gerrit

Event Timeline

Nikki created this task.Jun 21 2017, 12:48 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 21 2017, 12:48 PM
thiemowmde triaged this task as Lowest priority.Jun 28 2017, 7:06 PM
thiemowmde added projects: MediaWiki-extensions-WikibaseRepository, patch-welcome, good first task.
thiemowmde added a subscriber: thiemowmde.
Restricted Application added a subscriber: TerraCodes. · View Herald TranscriptJun 28 2017, 7:06 PM
gerritbot added a subscriber: gerritbot.Jul 2 2017, 1:04 PM

Change 362875 had a related patch set uploaded (by D3r1ck01; owner: Alangi Derick):
[mediawiki/extensions/Wikibase@master] Remove 'smj' from getMonolingualTextLanguages

https://gerrit.wikimedia.org/r/362875

gerritbot added a project: Patch-For-Review.Jul 2 2017, 1:04 PM
gerritbot added a comment.Jul 2 2017, 1:09 PM

Change 362876 had a related patch set uploaded (by D3r1ck01; owner: Alangi Derick):
[operations/mediawiki-config@master] Remove 'din' from wmgExtraLanguageNames

https://gerrit.wikimedia.org/r/362876

xSavitar claimed this task.Jul 2 2017, 1:10 PM
xSavitar added a project: Africa-Wikimedia-Developers.
xSavitar moved this task from Backlog to Upcoming Events on the Africa-Wikimedia-Developers board.
xSavitar moved this task from Upcoming Events to New Contributor's Tasks (Incoming) on the Africa-Wikimedia-Developers board.
gerritbot added a comment.Jul 3 2017, 8:07 AM

Change 362875 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Remove 'smj' from getMonolingualTextLanguages

https://gerrit.wikimedia.org/r/362875

xSavitar added a comment.Jul 5 2017, 10:12 AM

@Nikki, how about this change? https://gerrit.wikimedia.org/r/362876. This has been merged: https://gerrit.wikimedia.org/r/362875. But the former is still pending review.

xSavitar moved this task from New Contributor's Tasks (Incoming) to Tasks in progress (Doing) on the Africa-Wikimedia-Developers board.Jul 18 2017, 1:46 AM
gerritbot added a comment.Jul 19 2017, 6:34 PM

Change 362876 merged by jenkins-bot:
[operations/mediawiki-config@master] Remove 'din' from wmgExtraLanguageNames

https://gerrit.wikimedia.org/r/362876

Stashbot added a subscriber: Stashbot.Jul 19 2017, 6:40 PM

Mentioned in SAL (#wikimedia-operations) [2017-07-19T18:40:16Z] <niharika29@tin> Synchronized wmf-config/InitialiseSettings.php: Remove 'din' from wmgExtraLanguageNames [mediawiki-config] - https://gerrit.wikimedia.org/r/362876 (https://phabricator.wikimedia.org/T168523) (duration: 00m 47s)

xSavitar added a comment.Jul 19 2017, 8:13 PM

@Nikki, can this be marked as resolved?

Nikki added a comment.Jul 20 2017, 10:26 AM

Yes, it looks like it's fixed.

Ladsgroup closed this task as Resolved.Jul 20 2017, 10:35 AM
Ladsgroup removed a project: Patch-For-Review.
Ladsgroup added a subscriber: Ladsgroup.

Thanks!

xSavitar moved this task from Tasks in progress (Doing) to Technical Tasks (Completed) on the Africa-Wikimedia-Developers board.Sep 6 2017, 7:19 PM
Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL