Page MenuHomePhabricator
Create Task
Maniphest T168532

Check constraints on qualifiers and references
Closed, ResolvedPublic
Actions

Description

Currently, we only check constraints on the statement main snak. We should also check them on qualifiers and on references.

Details

SubjectRepoBranchLines +/-
Check constraints on qualifiers+references by defaultmediawiki/extensions/WikibaseQualityConstraintsmaster+2 -2
Remove support for old API output formatmediawiki/extensions/WikibaseQualityConstraintsmaster+117 -357
Use new API output format by defaultmediawiki/extensions/WikibaseQualityConstraintsmaster+11 -5
Add support for qualifier/reference reports to gadgetmediawiki/extensions/WikibaseQualityConstraintsmaster+60 -9
Add config for constraints on qualifiers/referencesmediawiki/extensions/WikibaseQualityConstraintsmaster+32 -2
Check constraints on qualifiers and referencesmediawiki/extensions/WikibaseQualityConstraintsmaster+105 -17
Check context type in QualifierCheckermediawiki/extensions/WikibaseQualityConstraintsmaster+33 -67
Refactor gadget.jsmediawiki/extensions/WikibaseQualityConstraintsmaster+73 -23
Add ReferenceContext implementation and testsmediawiki/extensions/WikibaseQualityConstraintsmaster+318 -0
Add QualifierContext implementation and testsmediawiki/extensions/WikibaseQualityConstraintsmaster+239 -0
Customize query in gerrit

Related Objects
Search...

StatusSubtypeAssignedTask
 ResolvedLucas_Werkmeister_WMDET173695 Enable constraint checks by default for users
 ResolvedLucas_Werkmeister_WMDET168532 Check constraints on qualifiers and references
 ResolvedLucas_Werkmeister_WMDET171743 Introduce constraint check context abstraction
 ResolvedLydia_PintscherT171762 Consider rank when checking constraints on qualifiers and references?
 ResolvedLucas_Werkmeister_WMDET102749 [Task] Implement "Value only constraint"
 ResolvedLucas_Werkmeister_WMDET171725 Add snak hashes to entity HTML output
 ResolvedthiemowmdeT171607 Main snak and reference snaks do not include hash in JSON output
 ResolvedLucas_Werkmeister_WMDET174011 Add snak IDs (hashes) to wikibase-datamodel-javascript
 ResolvedLucas_Werkmeister_WMDET176604 Snak hashes for qualifiers and references missing in entity HTML after statement save
 ResolvedLucas_Werkmeister_WMDET176633 Saved snaks have wikibase-snakview- class
 ResolvedLucas_Werkmeister_WMDET174544 Document, announce, and use new wbcheckconstraints API format on Wikidata
 ResolvedLucas_Werkmeister_WMDET175590 Switch to new wbcheckconstraints API format on Wikidata
 ResolvedLucas_Werkmeister_WMDET175561 Check distinct values (unique value) constraint on qualifiers and references
 OpenNoneT175562 Check “conflicts with” and “item requires claim” constraints on qualifiers and references?
 ResolvedLucas_Werkmeister_WMDET175565 Check “difference within range” constraints on qualifiers and references (days: 3)
 ResolvedLucas_Werkmeister_WMDET175566 Check “single value” and “multi value” constraints on qualifiers and references
 ResolvedLucas_Werkmeister_WMDET185209 Introduce “sibling snaks” abstraction
 ResolvedLucas_Werkmeister_WMDET175570 Don’t check some constraint types on non-statement contexts
 OpenNoneT175594 Check “symmetric” and “inverse” constraints on qualifiers and references?
 ResolvedLucas_Werkmeister_WMDET176863 Enable constraint checks on qualifiers and references on Wikidata
 ResolvedLucas_Werkmeister_WMDET166892 Implement “Reference” constraint
 ResolvedLucas_Werkmeister_WMDET177388 Check “type” constraint on qualifiers and references
 ResolvedLucas_Werkmeister_WMDET178147 Check “type” constraint on references?
 ResolvedLucas_Werkmeister_WMDET178295 Don’t always check “type” constraint on qualifiers
 ResolvedLucas_Werkmeister_WMDET183542 Support “constraint scope” parameter (days: 3)
 ResolvedLucas_Werkmeister_WMDET184202 Parse constraint scope parameter

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes
gerritbot subscribed.Aug 23 2017, 5:17 PM

Change 373322 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/WikibaseQualityConstraints@master] Add QualifierContext implementation and tests

https://gerrit.wikimedia.org/r/373322

gerritbot added a project: Patch-For-Review.Aug 23 2017, 5:17 PM
Lucas_Werkmeister_WMDE moved this task from Doing to Review on the Wikidata-Former-Sprint-Board board.Aug 23 2017, 5:18 PM
gerritbot added a comment.Aug 23 2017, 5:23 PM

Change 373323 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/WikibaseQualityConstraints@master] Refactor gadget.js

https://gerrit.wikimedia.org/r/373323

Lucas_Werkmeister_WMDE updated the task description. (Show Details)Aug 23 2017, 5:25 PM
Lucas_Werkmeister_WMDE added a subtask: T171725: Add snak hashes to entity HTML output.Aug 24 2017, 10:55 AM
Ivan_A_Krestinin subscribed.Aug 24 2017, 9:42 PM

About KrBot: current implementation fully ignores references and ranks. Qualifiers are checked only by https://www.wikidata.org/wiki/Q37845003 and https://www.wikidata.org/wiki/Q21510863. Also https://www.wikidata.org/wiki/Q19474404 constraint uses qualifiers if https://www.wikidata.org/wiki/Property:P4155 is specified. In other words: qualifiers are not checked too.

abian subscribed.Aug 28 2017, 8:39 PM
Lucas_Werkmeister_WMDE updated the task description. (Show Details)Aug 29 2017, 10:26 AM
Lucas_Werkmeister_WMDE created subtask T174544: Document, announce, and use new wbcheckconstraints API format on Wikidata.Aug 30 2017, 11:35 AM
Lucas_Werkmeister_WMDE updated the task description. (Show Details)
Lucas_Werkmeister_WMDE moved this task from Review to Doing on the Wikidata-Former-Sprint-Board board.
Lucas_Werkmeister_WMDE updated the task description. (Show Details)Aug 30 2017, 11:37 AM
gerritbot added a comment.Aug 31 2017, 12:17 PM

Change 373322 merged by Lucas Werkmeister (WMDE):
[mediawiki/extensions/WikibaseQualityConstraints@master] Add QualifierContext implementation and tests

https://gerrit.wikimedia.org/r/373322

Lucas_Werkmeister_WMDE updated the task description. (Show Details)Aug 31 2017, 12:18 PM
gerritbot added a comment.Aug 31 2017, 1:59 PM

Change 374995 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/WikibaseQualityConstraints@master] Add ReferenceContext implementation and tests

https://gerrit.wikimedia.org/r/374995

Lucas_Werkmeister_WMDE updated the task description. (Show Details)Aug 31 2017, 1:59 PM
Lucas_Werkmeister_WMDE moved this task from Doing to Review on the Wikidata-Former-Sprint-Board board.
thiemowmde closed subtask T171725: Add snak hashes to entity HTML output as Resolved.Sep 4 2017, 12:45 PM
WMDE-leszek moved this task from Review to Doing on the Wikidata-Former-Sprint-Board board.Sep 5 2017, 9:27 AM
gerritbot added a comment.Sep 5 2017, 10:50 AM

Change 374995 merged by jenkins-bot:
[mediawiki/extensions/WikibaseQualityConstraints@master] Add ReferenceContext implementation and tests

https://gerrit.wikimedia.org/r/374995

gerritbot added a comment.Sep 6 2017, 4:30 PM

Change 376290 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/WikibaseQualityConstraints@master] WIP: Check constraints on qualifiers and references

https://gerrit.wikimedia.org/r/376290

Lucas_Werkmeister_WMDE updated the task description. (Show Details)Sep 11 2017, 1:10 PM
Lucas_Werkmeister_WMDE created subtask T175561: Check distinct values (unique value) constraint on qualifiers and references.Sep 11 2017, 1:31 PM
Lucas_Werkmeister_WMDE created subtask T175562: Check “conflicts with” and “item requires claim” constraints on qualifiers and references?.Sep 11 2017, 1:35 PM
Lucas_Werkmeister_WMDE created subtask T175565: Check “difference within range” constraints on qualifiers and references (days: 3).Sep 11 2017, 1:38 PM
Lucas_Werkmeister_WMDE created subtask T175566: Check “single value” and “multi value” constraints on qualifiers and references.
Lucas_Werkmeister_WMDE created subtask T175570: Don’t check some constraint types on non-statement contexts.Sep 11 2017, 1:42 PM
gerritbot added a comment.Sep 11 2017, 2:12 PM

Change 377267 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/WikibaseQualityConstraints@master] Check context type in QualifierChecker

https://gerrit.wikimedia.org/r/377267

Lucas_Werkmeister_WMDE created subtask T175594: Check “symmetric” and “inverse” constraints on qualifiers and references?.Sep 11 2017, 3:56 PM
gerritbot added a comment.Sep 14 2017, 9:09 AM

Change 373323 merged by jenkins-bot:
[mediawiki/extensions/WikibaseQualityConstraints@master] Refactor gadget.js

https://gerrit.wikimedia.org/r/373323

gerritbot added a comment.Sep 19 2017, 1:17 PM

Change 377267 merged by jenkins-bot:
[mediawiki/extensions/WikibaseQualityConstraints@master] Check context type in QualifierChecker

https://gerrit.wikimedia.org/r/377267

Lucas_Werkmeister_WMDE closed subtask T175570: Don’t check some constraint types on non-statement contexts as Resolved.Sep 19 2017, 1:25 PM
Lucas_Werkmeister_WMDE reopened subtask T175570: Don’t check some constraint types on non-statement contexts as Open.Sep 19 2017, 3:23 PM
Lucas_Werkmeister_WMDE closed subtask T175570: Don’t check some constraint types on non-statement contexts as Resolved.Sep 20 2017, 11:55 AM
Lucas_Werkmeister_WMDE updated the task description. (Show Details)Sep 22 2017, 11:51 AM
gerritbot added a comment.Sep 22 2017, 1:02 PM

Change 379746 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/WikibaseQualityConstraints@master] Check constraints on qualifiers and references

https://gerrit.wikimedia.org/r/379746

gerritbot added a comment.Sep 22 2017, 1:02 PM

Change 379747 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/WikibaseQualityConstraints@master] Add support for qualifier/reference reports to gadget

https://gerrit.wikimedia.org/r/379747

Lucas_Werkmeister_WMDE updated the task description. (Show Details)Sep 22 2017, 1:03 PM
Lucas_Werkmeister_WMDE moved this task from Doing to Review on the Wikidata-Former-Sprint-Board board.
Lucas_Werkmeister_WMDE updated the task description. (Show Details)
Lucas_Werkmeister_WMDE mentioned this in T176604: Snak hashes for qualifiers and references missing in entity HTML after statement save.Sep 26 2017, 9:47 AM
Lucas_Werkmeister_WMDE mentioned this in T176863: Enable constraint checks on qualifiers and references on Wikidata.Sep 27 2017, 12:43 PM
Lucas_Werkmeister_WMDE created subtask T176863: Enable constraint checks on qualifiers and references on Wikidata.
Lucas_Werkmeister_WMDE updated the task description. (Show Details)
Lucas_Werkmeister_WMDE added a subtask: T166892: Implement “Reference” constraint.Sep 27 2017, 1:34 PM
gerritbot added a comment.Sep 29 2017, 10:04 AM

Change 376290 merged by jenkins-bot:
[mediawiki/extensions/WikibaseQualityConstraints@master] Add config for constraints on qualifiers/references

https://gerrit.wikimedia.org/r/376290

gerritbot added a comment.Sep 29 2017, 10:04 AM

Change 379746 merged by jenkins-bot:
[mediawiki/extensions/WikibaseQualityConstraints@master] Check constraints on qualifiers and references

https://gerrit.wikimedia.org/r/379746

ReleaseTaggerBot added a project: MW-1.30-release-notes (WMF-deploy-2017-07-25_(1.30.0-wmf.11)).Sep 29 2017, 11:00 AM
Lucas_Werkmeister_WMDE updated the task description. (Show Details)Oct 2 2017, 8:53 AM
Lucas_Werkmeister_WMDE closed subtask T102749: [Task] Implement "Value only constraint" as Resolved.Oct 2 2017, 9:13 AM
• Jonas removed a project: Patch-For-Review.Oct 2 2017, 1:03 PM
• Jonas updated the task description. (Show Details)
• Jonas moved this task from Review to Doing on the Wikidata-Former-Sprint-Board board.
gerritbot added a comment.Oct 2 2017, 1:13 PM

Change 379747 merged by jenkins-bot:
[mediawiki/extensions/WikibaseQualityConstraints@master] Add support for qualifier/reference reports to gadget

https://gerrit.wikimedia.org/r/379747

Lucas_Werkmeister_WMDE removed a project: Wikidata-Former-Sprint-Board.Oct 2 2017, 1:15 PM
Lucas_Werkmeister_WMDE created subtask T177388: Check “type” constraint on qualifiers and references.Oct 4 2017, 12:29 PM
Lucas_Werkmeister_WMDE closed subtask T177388: Check “type” constraint on qualifiers and references as Resolved.Oct 5 2017, 10:01 AM
Lucas_Werkmeister_WMDE closed subtask T166892: Implement “Reference” constraint as Resolved.Oct 9 2017, 12:12 PM
Lucas_Werkmeister_WMDE closed subtask T175561: Check distinct values (unique value) constraint on qualifiers and references as Resolved.Oct 9 2017, 4:42 PM
Lucas_Werkmeister_WMDE closed subtask T174544: Document, announce, and use new wbcheckconstraints API format on Wikidata as Resolved.Oct 10 2017, 1:38 PM
Lucas_Werkmeister_WMDE updated the task description. (Show Details)
Lucas_Werkmeister_WMDE closed subtask T176863: Enable constraint checks on qualifiers and references on Wikidata as Resolved.Oct 11 2017, 2:04 PM
Lucas_Werkmeister_WMDE updated the task description. (Show Details)
Lucas_Werkmeister_WMDE created subtask T178147: Check “type” constraint on references?.Oct 13 2017, 9:19 AM
Lucas_Werkmeister_WMDE created subtask T178295: Don’t always check “type” constraint on qualifiers.Oct 16 2017, 2:08 PM
gerritbot added a comment.Oct 20 2017, 3:17 PM

Change 385387 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/WikibaseQualityConstraints@master] Use new API output format by default

https://gerrit.wikimedia.org/r/385387

gerritbot added a project: Patch-For-Review.Oct 20 2017, 3:17 PM

Change 385388 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/WikibaseQualityConstraints@master] Remove support for old API output format

https://gerrit.wikimedia.org/r/385388

Lucas_Werkmeister_WMDE updated the task description. (Show Details)Oct 20 2017, 3:17 PM
Lucas_Werkmeister_WMDE added a project: Wikidata-Former-Sprint-Board.
Lucas_Werkmeister_WMDE moved this task from Doing to Review on the Wikidata-Former-Sprint-Board board.
gerritbot added a comment.Oct 21 2017, 5:57 PM

Change 385387 merged by jenkins-bot:
[mediawiki/extensions/WikibaseQualityConstraints@master] Use new API output format by default

https://gerrit.wikimedia.org/r/385387

gerritbot added a comment.Oct 21 2017, 5:57 PM

Change 385388 merged by jenkins-bot:
[mediawiki/extensions/WikibaseQualityConstraints@master] Remove support for old API output format

https://gerrit.wikimedia.org/r/385388

ReleaseTaggerBot added a project: MW-1.31-release-notes (WMF-deploy-2017-10-24 (1.31.0-wmf.5)).Oct 21 2017, 6:00 PM
Lucas_Werkmeister_WMDE updated the task description. (Show Details)Oct 23 2017, 10:16 AM
Lucas_Werkmeister_WMDE moved this task from Review to Doing on the Wikidata-Former-Sprint-Board board.
gerritbot added a comment.Oct 23 2017, 11:10 AM

Change 385961 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/WikibaseQualityConstraints@master] Check constraints on qualifiers references by default

https://gerrit.wikimedia.org/r/385961

Lucas_Werkmeister_WMDE updated the task description. (Show Details)Oct 23 2017, 11:11 AM
Lucas_Werkmeister_WMDE moved this task from Doing to Review on the Wikidata-Former-Sprint-Board board.
gerritbot added a comment.Oct 25 2017, 6:24 AM

Change 385961 merged by jenkins-bot:
[mediawiki/extensions/WikibaseQualityConstraints@master] Check constraints on qualifiers references by default

https://gerrit.wikimedia.org/r/385961

Lucas_Werkmeister_WMDE closed this task as Resolved.Oct 25 2017, 8:39 AM
Lucas_Werkmeister_WMDE claimed this task.
Lucas_Werkmeister_WMDE updated the task description. (Show Details)
Lucas_Werkmeister_WMDE moved this task from Review to Done on the Wikidata-Former-Sprint-Board board.

Closing this task as resolved, though some of the subtasks are still open.

ReleaseTaggerBot edited projects, added MW-1.31-release-notes (WMF-deploy-2017-10-31 (1.31.0-wmf.6)); removed MW-1.31-release-notes (WMF-deploy-2017-10-24 (1.31.0-wmf.5)).Oct 30 2017, 3:01 PM
Lucas_Werkmeister_WMDE closed subtask T178147: Check “type” constraint on references? as Resolved.Nov 7 2017, 11:23 AM
Lucas_Werkmeister_WMDE mentioned this in T179849: Cache all constraint check results per-entity.Nov 21 2017, 4:16 PM
Lucas_Werkmeister_WMDE mentioned this in T183542: Support “constraint scope” parameter (days: 3).Jan 5 2018, 12:15 PM
Lucas_Werkmeister_WMDE closed subtask T178295: Don’t always check “type” constraint on qualifiers as Resolved.Jan 19 2018, 1:43 PM
Lucas_Werkmeister_WMDE closed subtask T175566: Check “single value” and “multi value” constraints on qualifiers and references as Resolved.Jan 23 2018, 5:26 PM
Lucas_Werkmeister_WMDE closed subtask T175565: Check “difference within range” constraints on qualifiers and references (days: 3) as Resolved.Jan 24 2018, 5:44 PM
Lucas_Werkmeister_WMDE mentioned this in T188728: Replace claim with violation message in Special:ConstraintReport.Mar 2 2018, 1:15 PM
Lydia_Pintscher closed subtask T171762: Consider rank when checking constraints on qualifiers and references? as Resolved.Apr 6 2018, 3:57 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL