Check constraints on qualifiers and references
Closed, ResolvedPublic

Description

Currently, we only check constraints on the statement main snak. We should also check them on qualifiers and on references.

Related Objects

StatusAssignedTask
ResolvedLucas_Werkmeister_WMDE
ResolvedLucas_Werkmeister_WMDE
ResolvedLucas_Werkmeister_WMDE
ResolvedLydia_Pintscher
ResolvedLucas_Werkmeister_WMDE
ResolvedLucas_Werkmeister_WMDE
Resolvedthiemowmde
ResolvedLucas_Werkmeister_WMDE
ResolvedLucas_Werkmeister_WMDE
ResolvedLucas_Werkmeister_WMDE
ResolvedLucas_Werkmeister_WMDE
ResolvedLucas_Werkmeister_WMDE
ResolvedLucas_Werkmeister_WMDE
OpenNone
ResolvedLucas_Werkmeister_WMDE
ResolvedLucas_Werkmeister_WMDE
ResolvedLucas_Werkmeister_WMDE
ResolvedLucas_Werkmeister_WMDE
OpenNone
ResolvedLucas_Werkmeister_WMDE
ResolvedLucas_Werkmeister_WMDE
ResolvedLucas_Werkmeister_WMDE
ResolvedLucas_Werkmeister_WMDE
ResolvedLucas_Werkmeister_WMDE
ResolvedLucas_Werkmeister_WMDE
ResolvedLucas_Werkmeister_WMDE
There are a very large number of changes, so older changes are hidden. Show Older Changes

Change 373322 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/WikibaseQualityConstraints@master] Add QualifierContext implementation and tests

https://gerrit.wikimedia.org/r/373322

Change 373323 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/WikibaseQualityConstraints@master] Refactor gadget.js

https://gerrit.wikimedia.org/r/373323

About KrBot: current implementation fully ignores references and ranks. Qualifiers are checked only by https://www.wikidata.org/wiki/Q37845003 and https://www.wikidata.org/wiki/Q21510863. Also https://www.wikidata.org/wiki/Q19474404 constraint uses qualifiers if https://www.wikidata.org/wiki/Property:P4155 is specified. In other words: qualifiers are not checked too.

abian added a subscriber: abian.Aug 28 2017, 8:39 PM

Change 373322 merged by Lucas Werkmeister (WMDE):
[mediawiki/extensions/WikibaseQualityConstraints@master] Add QualifierContext implementation and tests

https://gerrit.wikimedia.org/r/373322

Change 374995 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/WikibaseQualityConstraints@master] Add ReferenceContext implementation and tests

https://gerrit.wikimedia.org/r/374995

Change 374995 merged by jenkins-bot:
[mediawiki/extensions/WikibaseQualityConstraints@master] Add ReferenceContext implementation and tests

https://gerrit.wikimedia.org/r/374995

Change 376290 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/WikibaseQualityConstraints@master] WIP: Check constraints on qualifiers and references

https://gerrit.wikimedia.org/r/376290

Change 377267 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/WikibaseQualityConstraints@master] Check context type in QualifierChecker

https://gerrit.wikimedia.org/r/377267

Change 373323 merged by jenkins-bot:
[mediawiki/extensions/WikibaseQualityConstraints@master] Refactor gadget.js

https://gerrit.wikimedia.org/r/373323

Change 377267 merged by jenkins-bot:
[mediawiki/extensions/WikibaseQualityConstraints@master] Check context type in QualifierChecker

https://gerrit.wikimedia.org/r/377267

Change 379746 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/WikibaseQualityConstraints@master] Check constraints on qualifiers and references

https://gerrit.wikimedia.org/r/379746

Change 379747 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/WikibaseQualityConstraints@master] Add support for qualifier/reference reports to gadget

https://gerrit.wikimedia.org/r/379747

Lucas_Werkmeister_WMDE moved this task from Doing to Review on the Wikidata-Former-Sprint-Board board.
Lucas_Werkmeister_WMDE updated the task description. (Show Details)

Change 376290 merged by jenkins-bot:
[mediawiki/extensions/WikibaseQualityConstraints@master] Add config for constraints on qualifiers/references

https://gerrit.wikimedia.org/r/376290

Change 379746 merged by jenkins-bot:
[mediawiki/extensions/WikibaseQualityConstraints@master] Check constraints on qualifiers and references

https://gerrit.wikimedia.org/r/379746

Jonas updated the task description. (Show Details)
Jonas moved this task from Review to Doing on the Wikidata-Former-Sprint-Board board.

Change 379747 merged by jenkins-bot:
[mediawiki/extensions/WikibaseQualityConstraints@master] Add support for qualifier/reference reports to gadget

https://gerrit.wikimedia.org/r/379747

Change 385387 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/WikibaseQualityConstraints@master] Use new API output format by default

https://gerrit.wikimedia.org/r/385387

Change 385388 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/WikibaseQualityConstraints@master] Remove support for old API output format

https://gerrit.wikimedia.org/r/385388

Change 385387 merged by jenkins-bot:
[mediawiki/extensions/WikibaseQualityConstraints@master] Use new API output format by default

https://gerrit.wikimedia.org/r/385387

Change 385388 merged by jenkins-bot:
[mediawiki/extensions/WikibaseQualityConstraints@master] Remove support for old API output format

https://gerrit.wikimedia.org/r/385388

Change 385961 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/WikibaseQualityConstraints@master] Check constraints on qualifiers references by default

https://gerrit.wikimedia.org/r/385961

Change 385961 merged by jenkins-bot:
[mediawiki/extensions/WikibaseQualityConstraints@master] Check constraints on qualifiers references by default

https://gerrit.wikimedia.org/r/385961

Lucas_Werkmeister_WMDE closed this task as Resolved.
Lucas_Werkmeister_WMDE moved this task from Review to Done on the Wikidata-Former-Sprint-Board board.
Lucas_Werkmeister_WMDE claimed this task.

Closing this task as resolved, though some of the subtasks are still open.