Page MenuHomePhabricator

Bad grep statement in viwiki editquality make rules?
Closed, ResolvedPublic

Description

datasets/viwiki.revisions_to_review.5k_2015.json: \
        datasets/viwiki.autolabeled_revisions.500k_2015.json
    (cat $< | grep True | \
     shuf -n 2500; \
     cat $< | grep False | \
     shuf -n 2500 \
    ) | shuf > $@

All the other places in this makefile where we grep for review, it's either

grep '"needs_review": true'

or

grep '"reverted_for_damage": true'