Automatically switch input parameters when they were used wrong
Closed, ResolvedPublic2 Estimated Story PointsBUG REPORT
Actions

Assigned To

Authored By

	WMDE-Fisch
	Jun 22 2017, 9:03 AM

Description

When a user shares a link where the diff parameter contains the actual oldid and the other way around. See:

https://en.wikipedia.beta.wmflabs.org/w/index.php?diff=158491&oldid=172031&title=Main_Page&type=revision

The RevisionSlider then shows the yellow pointer off grid. Instead it should automatically detect the wrong usage ( e.g. by looking at the timestamp ) and switch the parameters.

( By feedback in https://www.mediawiki.org/wiki/Topic:Tpejiph9fv818kil )

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	Fix broken initial state when old/new revision id are swapped	mediawiki/extensions/RevisionSlider	master	+1 -1

Customize query in gerrit

Event Timeline

WMDE-Fisch created this task.Jun 22 2017, 9:03 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 22 2017, 9:03 AM

• Lea_WMDE moved this task from Incoming to Watching on the Revision-Slider board.Jul 4 2017, 1:53 PM

Tobi_WMDE_SW moved this task from Incoming to Revision Slider on the TCB-Team (now WMDE-TechWish) board.Oct 10 2017, 9:39 AM

thiemowmde removed a project: TCB-Team (now WMDE-TechWish).Jan 7 2022, 3:06 PM

thiemowmde added a project: WMDE-TechWish-Maintenance.Jan 19 2022, 11:36 AM

thiemowmde changed the subtype of this task from "Task" to "Bug Report".

Change 831047 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/RevisionSlider@master] Fix broken initial state when old/new revision id are swapped

https://gerrit.wikimedia.org/r/831047

gerritbot added a project: Patch-For-Review.Sep 9 2022, 9:22 AM

thiemowmde moved this task from Incoming to In progress on the WMDE-TechWish-Maintenance board.Sep 9 2022, 9:36 AM

Change 831047 merged by jenkins-bot:

[mediawiki/extensions/RevisionSlider@master] Fix broken initial state when old/new revision id are swapped

https://gerrit.wikimedia.org/r/831047

ReleaseTaggerBot added a project: MW-1.40-notes (1.40.0-wmf.1; 2022-09-12).Sep 12 2022, 7:00 AM

Maintenance_bot removed a project: Patch-For-Review.Sep 12 2022, 7:30 AM

thiemowmde claimed this task.Sep 14 2022, 1:54 PM

thiemowmde set the point value for this task to 2.

thiemowmde added a project: WMDE-TechWish-Sprint-2022-09-14.

thiemowmde moved this task from Sprint Backlog to Demo on the WMDE-TechWish-Sprint-2022-09-14 board.

thiemowmde closed this task as Resolved.Sep 27 2022, 8:27 AM

Automatically switch input parameters when they were used wrongClosed, ResolvedPublic2 Estimated Story PointsBUG REPORTActions

Description

Details

Event Timeline

Automatically switch input parameters when they were used wrong
Closed, ResolvedPublic2 Estimated Story PointsBUG REPORT
Actions