Page MenuHomePhabricator
Create Task
Maniphest T168669

Sniff to disallow PHP 7 Unicode escape syntax
Closed, ResolvedPublic
Actions

Description

https://gerrit.wikimedia.org/r/#/c/360855/

Details

SubjectRepoBranchLines +/-
Add sniff to prevent against using PHP 7's Unicode escape syntaxmediawiki/tools/codesniffermaster+103 -0
Customize query in gerrit

Event Timeline

Legoktm created this task.Jun 22 2017, 5:24 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 22 2017, 5:24 PM
gerritbot subscribed.Jun 22 2017, 10:01 PM

Change 360987 had a related patch set uploaded (by Legoktm; owner: Legoktm):
[mediawiki/tools/codesniffer@master] Add sniff to prevent against using PHP 7's Unicode escape syntax

https://gerrit.wikimedia.org/r/360987

gerritbot added a project: Patch-For-Review.Jun 22 2017, 10:01 PM
Esanders awarded a token.Jun 22 2017, 11:35 PM
Krinkle triaged this task as High priority.Jun 23 2017, 1:20 AM
Krinkle awarded a token.
Krinkle subscribed.
Ricordisamoa subscribed.Jun 23 2017, 4:07 PM
gerritbot added a comment.Jun 23 2017, 5:53 PM

Change 360987 merged by jenkins-bot:
[mediawiki/tools/codesniffer@master] Add sniff to prevent against using PHP 7's Unicode escape syntax

https://gerrit.wikimedia.org/r/360987

Legoktm closed this task as Resolved.Jun 23 2017, 6:11 PM
Legoktm claimed this task.
• MZMcBride subscribed.Jun 24 2017, 3:09 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL