Page MenuHomePhabricator
Create Task
Maniphest T168694

Regression: Yet another PointerOverlay UI regression
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

Visit https://en.m.wikipedia.beta.wmflabs.org/wiki/Headings?article_action=signup-edit when logged in

Expected:

Screen Shot 2017-06-22 at 4.46.12 PM.png (416×1 px, 65 KB)

Actual:

Screen Shot 2017-06-22 at 4.46.17 PM.png (469×1 px, 161 KB)

I expect I'm to blame.. sorry.

Details

SubjectRepoBranchLines +/-
Address padding/button width in pointer overlay UI regressionmediawiki/extensions/MobileFrontendmaster+2 -2
Customize query in gerrit

Related Objects

Event Timeline

Jdlrobson created this task.Jun 22 2017, 11:46 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 22 2017, 11:46 PM
Jdlrobson added projects: Readers-Web-Kanbanana-Board-Old, Unplanned-Sprint-Work.Jun 22 2017, 11:47 PM
Jdlrobson moved this task from To Do to Needs Design Review on the Readers-Web-Kanbanana-Board-Old board.
Jdlrobson moved this task from Needs Design Review to Doing on the Readers-Web-Kanbanana-Board-Old board.Jun 22 2017, 11:52 PM
gerritbot subscribed.Jun 22 2017, 11:53 PM

Change 361014 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/extensions/MobileFrontend@master] Address padding/button width in pointer overlay UI regression

https://gerrit.wikimedia.org/r/361014

gerritbot added a project: Patch-For-Review.Jun 22 2017, 11:53 PM
Jdlrobson claimed this task.Jun 22 2017, 11:53 PM
Jdlrobson moved this task from Doing to Needs Code Review on the Readers-Web-Kanbanana-Board-Old board.
phuedx updated the task description. (Show Details)Jun 23 2017, 10:30 AM
phuedx subscribed.Jun 23 2017, 10:43 AM

I'm reviewing rEMFR43f85fd707a6: Address padding/button width in pointer overlay UI regression…

gerritbot added a comment.Jun 23 2017, 11:07 AM

Change 361014 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend@master] Address padding/button width in pointer overlay UI regression

https://gerrit.wikimedia.org/r/361014

ovasileva moved this task from Incoming to 2016-17 Q4 on the Web-Team-Backlog board.Jun 23 2017, 11:51 AM
ReleaseTaggerBot added a project: MW-1.30-release-notes (WMF-deploy-2017-06-27_(1.30.0-wmf.7)).Jun 23 2017, 12:00 PM
phuedx reassigned this task from Jdlrobson to ABorbaWMF.Jun 23 2017, 12:14 PM
phuedx moved this task from Needs Code Review to Needs QA on the Readers-Web-Kanbanana-Board-Old board.
phuedx added a subscriber: ABorbaWMF.

@ABorbaWMF: See the instructions in the description.

ABorbaWMF moved this task from Needs QA to Ready for Signoff on the Readers-Web-Kanbanana-Board-Old board.Jun 23 2017, 6:03 PM

Heading looks good now. I tried it on a variety of mobile devices and browsers.

phuedx triaged this task as High priority.Jun 26 2017, 8:43 AM
phuedx set the point value for this task to 1.

Not UBN as it doesn't stop folk interacting with the overlay.

phuedx closed this task as Resolved.Jun 26 2017, 8:44 AM
phuedx claimed this task.

Nice catch and fix, @Jdlrobson!

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL