Page MenuHomePhabricator

DraggableElement / DraggableGroupElement should have no skin styles applied.
Closed, ResolvedPublic1 Story Points

Description

These are abstract mixins. Theme styles should only be being applied to specific widgets, or for theme-agnostic behaviour (e.g. cursor styles). The styles applied (padding/border-radius) seem to be for the demo widget DraggableGroupWidget, so these styles should be moved there.

This cased a regression in the VE gallery dialog, which mixes in DraggableElement, but doesn't use any padding:

Event Timeline

Esanders created this task.Jun 23 2017, 6:56 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 23 2017, 6:56 PM

Change 361088 had a related patch set uploaded (by Esanders; owner: Esanders):
[mediawiki/extensions/VisualEditor@master] GalleryDialog: Downstream fix for DraggableElement padding

https://gerrit.wikimedia.org/r/361088

Change 361089 had a related patch set uploaded (by Esanders; owner: Esanders):
[oojs/ui@master] Remove DraggableElement styles

https://gerrit.wikimedia.org/r/361089

Change 361088 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] GalleryDialog: Downstream fix for DraggableElement padding

https://gerrit.wikimedia.org/r/361088

Deskana closed this task as Resolved.Jun 26 2017, 11:08 AM
Deskana assigned this task to Esanders.
Deskana set the point value for this task to 1.
Restricted Application added a project: User-Ryasmeen. · View Herald TranscriptJun 26 2017, 11:08 AM

Change 361089 merged by jenkins-bot:
[oojs/ui@master] WikimediaUI theme: Remove default DraggableElement styling

https://gerrit.wikimedia.org/r/361089