DraggableElement / DraggableGroupElement should have no skin styles applied.
Closed, ResolvedPublic1 Estimated Story Points
Actions

Assigned To

Authored By

	Esanders
	Jun 23 2017, 6:56 PM

Description

These are abstract mixins. Theme styles should only be being applied to specific widgets, or for theme-agnostic behaviour (e.g. cursor styles). The styles applied (padding/border-radius) seem to be for the demo widget DraggableGroupWidget, so these styles should be moved there.

This cased a regression in the VE gallery dialog, which mixes in DraggableElement, but doesn't use any padding:

Details

	Subject	Repo	Branch	Lines +/-
	WikimediaUI theme: Remove default DraggableElement styling	oojs/ui	master	+1 -9
	GalleryDialog: Downstream fix for DraggableElement padding	mediawiki/extensions/VisualEditor	master	+3 -0

Customize query in gerrit

Event Timeline

Esanders created this task.Jun 23 2017, 6:56 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 23 2017, 6:56 PM

Change 361088 had a related patch set uploaded (by Esanders; owner: Esanders):
[mediawiki/extensions/VisualEditor@master] GalleryDialog: Downstream fix for DraggableElement padding

https://gerrit.wikimedia.org/r/361088

gerritbot added a project: Patch-For-Review.Jun 23 2017, 6:58 PM

Change 361089 had a related patch set uploaded (by Esanders; owner: Esanders):
[oojs/ui@master] Remove DraggableElement styles

https://gerrit.wikimedia.org/r/361089

Change 361088 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] GalleryDialog: Downstream fix for DraggableElement padding

https://gerrit.wikimedia.org/r/361088

ReleaseTaggerBot added a project: MW-1.30-release-notes (WMF-deploy-2017-06-27_(1.30.0-wmf.7)).Jun 26 2017, 11:00 AM

• Deskana closed this task as Resolved.Jun 26 2017, 11:08 AM

• Deskana assigned this task to Esanders.

• Deskana set the point value for this task to 1.

Restricted Application added a project: User-Ryasmeen. · View Herald TranscriptJun 26 2017, 11:08 AM

Ryasmeen edited projects, added Verified; removed Patch-For-Review.Jun 27 2017, 12:42 AM

Change 361089 merged by jenkins-bot:
[oojs/ui@master] WikimediaUI theme: Remove default DraggableElement styling

https://gerrit.wikimedia.org/r/361089

Ryasmeen added a project: Verified-in-Phase0.Jun 29 2017, 12:46 AM

Volker_E moved this task from Backlog to Waiting for breaking release on the OOUI board.Jun 30 2017, 11:38 AM

Volker_E moved this task from Waiting for breaking release to Resolved outside releases on the OOUI board.Mar 22 2018, 5:40 AM

DraggableElement / DraggableGroupElement should have no skin styles applied.Closed, ResolvedPublic1 Estimated Story PointsActions

Description

Details

Event Timeline

DraggableElement / DraggableGroupElement should have no skin styles applied.
Closed, ResolvedPublic1 Estimated Story Points
Actions