Page MenuHomePhabricator

It appears that NWE doesn't save edits but it does (hu.wp on-wiki script issue)
Closed, ResolvedPublic1 Estimated Story Points

Description

In the previous few days I've noticed that there is a problem after I save my edits. For example, today I wanted to save this comment on huWiki. I filled the edit summary and saved the page. But the saving-tab didn’t disappear (as you can see on the left side of the picture) but the edit summary was empty again.

In summary it looks like my edit hasn’t happened yet. But as you can see on the recent changes ("friss változtatások", blue text on the right side) my edit was successful. The problem is that the user cannot decide that the edit happened or not and if you want to close the tab the browser asks you “are you sure to close the tab?” so it looks the edit wasn’t successful.

This has happened with me only just few times (never in the main namespace). Any idea?

Képernyőfelvétel (123).png (768×1 px, 257 KB)

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Deskana changed the task status from Open to Stalled.Jun 26 2017, 4:31 PM
Deskana subscribed.

It's difficult to diagnose intermittent issues like this, as being able to reproduce this consistently is necessary to fix it. Next time it happens, can you open your browser console and see if there's some kind of error in there? That would help us a lot.

@Deskana It has happened again. I try to reproduce and record the bug.

Képkivágás.PNG (728×1 px, 91 KB)

@Deskana I could record the bug (edit, see the video). Three times out of my last three edits the bug was appeared when I edited "Wikipédia:Botgazdák üzenőfala" (Wikipedia:Bot requests).

Does the issue also occur when you disable https://hu.wikipedia.org/wiki/MediaWiki:Gadget-defaultsummaries.js (which adds the dropdowns below the summary input)?

I edited that same page and managed to reproduce the problem. My edit saved, but it didn't seem to. There was an error in the JavaScript console which I captured below. (Ignore the pink background)

Screen Shot 2017-06-27 at 17.54.11.png (864×2 px, 533 KB)

Deskana changed the task status from Stalled to Open.Jun 27 2017, 4:59 PM
Deskana triaged this task as Medium priority.
Deskana moved this task from To Triage to TR1: Releases on the VisualEditor board.

It's still happening, but the most annoying thing is that I don't meet with this bug on other pumps

@Tacsipacsi This edit doesn't look right: https://hu.wikipedia.org/w/index.php?title=MediaWiki:Gadget-wikimenu.js&diff=18825898&oldid=18016601

This is wrong:

var $ret = getMenuItems( $( '#wikiMenu-' + $cdiv.attr( 'title' ) ).replace(/<>/g, ''), level + 1 );

It should probably be:

var $ret = getMenuItems( $( '#wikiMenu-' + $cdiv.attr( 'title' ).replace(/<>/g, '') ), level + 1 );

(As a side note, VE probably shouldn't fail in this manner when faced with faulty 'wikipage.content' hook handlers. We should run them in a setTimeout() or try…catch something.)

@matmarex Thanks your answer! If Tacsipacsi has some time (because I cannot edit the page) and can fix it, I'll test it again.

Wikimenu fixed (I hope). However, I’d keep this task open as VE should disappear regardless of the wikipage.content handlers’ errors (I think the dialog should disappear before calling them).

On second thought… no uses of 'wikipage.content' anywhere seem to try to avoid this problem. I'm not sure if that's maybe intentional somehow?

@matmarex Today I've tested it and it looks like the problem has been solved. Thank you (and also @Tacsipacsi too)!

matmarex renamed this task from It appears that NWE doesn't save edits but it does to It appears that NWE doesn't save edits but it does (hu.wp on-wiki script issue).Jul 28 2017, 7:16 PM
matmarex closed this task as Resolved.
matmarex claimed this task.