Page MenuHomePhabricator

Adjust color of some filter actions to make them less prominent
Closed, DeclinedPublic


Currently the actions to bookmark, clear filters and the quick access to advanced filters are integrated into he "active filters" area. These icons are presented in pure black (#000) color:

rc-current-crop.png (125×225 px, 3 KB)

Adjusting the icons to use Base20 (#54595D) instead would make them to integrate better in the area:

RC-icon-color-adjust.png (131×241 px, 2 KB)

(the image also reflects other separate adjustments: T168835 and T168828 )

Event Timeline

They're not pure black currently: all iconed OOUI buttons have opacity: 0.87 to make the icons look like #222. When hovered, this changes to opacity: 0.73 to simulate #444 (in actual fact 0.73 is more like #454545).

If we want, we can apply opacity: 0.65 to simulate #595959 (the closest we can get to #54595D), but then we also have to define what the hover opacity should be. I'm attaching a patch that sets opacity: 0.65 but the problem with that is that the hover opacity is still 0.73, so the icons become slightly darker when hovered. I tried stacking opacities (setting 0.65/0.87 = 0.747 on the parent so it multiplies out to 0.65 when not hovered and a scaled version thereof (0.545) when hovered), but that had undesirable effects because the parent opacity affects the whole button including its background and borders, not just the icon.

Change 361601 had a related patch set uploaded (by Catrope; owner: Catrope):
[mediawiki/core@master] [WIP] RCFilters: Make view switch and save/reset buttons lighter

Change 361601 abandoned by Jforrester:
[WIP] RCFilters: Make view switch and save/reset buttons lighter

Declining task.

Jdforrester-WMF subscribed.

Over-riding the behaviour of our standardised widgets is not desirable. It reduces the coherence of the design, increases the engineering cost, and potentially adds to the cognitive load of users. I don't think this is a good approach.