| Pginer-WMF | |
| Jun 26 2017, 10:21 AM |
| F8530057: rc-current-crop.png | |
| Jun 26 2017, 10:21 AM |
| F8530269: RC-icon-color-adjust.png | |
| Jun 26 2017, 10:21 AM |
Currently the actions to bookmark, clear filters and the quick access to advanced filters are integrated into he "active filters" area. These icons are presented in pure black (#000) color:
Adjusting the icons to use Base20 (#54595D) instead would make them to integrate better in the area:
(the image also reflects other separate adjustments: T168835 and T168828 )
| Subject | Author | Repo | Branch | Lines +/- | |
|---|---|---|---|---|---|
| [WIP] RCFilters: Make view switch and save/reset buttons lighter | Catrope | mediawiki/core | master | +12 -0 |
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | SBisson | T162675 'Integrated filters'—add all RC Page filters into the new UI along with selected new functions | |||
| Open | None | T168826 Styling adjustments for the New filters for edit review | |||
| Declined | None | T168841 Adjust color of some filter actions to make them less prominent |
They're not pure black currently: all iconed OOUI buttons have opacity: 0.87 to make the icons look like #222. When hovered, this changes to opacity: 0.73 to simulate #444 (in actual fact 0.73 is more like #454545).
If we want, we can apply opacity: 0.65 to simulate #595959 (the closest we can get to #54595D), but then we also have to define what the hover opacity should be. I'm attaching a patch that sets opacity: 0.65 but the problem with that is that the hover opacity is still 0.73, so the icons become slightly darker when hovered. I tried stacking opacities (setting 0.65/0.87 = 0.747 on the parent so it multiplies out to 0.65 when not hovered and a scaled version thereof (0.545) when hovered), but that had undesirable effects because the parent opacity affects the whole button including its background and borders, not just the icon.
Change 361601 had a related patch set uploaded (by Catrope; owner: Catrope):
[mediawiki/core@master] [WIP] RCFilters: Make view switch and save/reset buttons lighter
Change 361601 abandoned by Jforrester:
[WIP] RCFilters: Make view switch and save/reset buttons lighter
Reason:
Declining task.
Over-riding the behaviour of our standardised widgets is not desirable. It reduces the coherence of the design, increases the engineering cost, and potentially adds to the cognitive load of users. I don't think this is a good approach.