Page MenuHomePhabricator

Use standard round corners for advanced filters buttons on the filters panel
Closed, ResolvedPublic


At the bottom of the regular filters panel there is access to the advanced filters, presented as a set of regular buttons one after the other. However, these buttons do not have the usual 2px rounded corners in all their edges:

Screen Shot 2017-06-26 at 13.44.12.png (195×707 px, 20 KB)

As shown in the image above, the right-side corners of the "Namespaces" button and the left-side corners of the "Tagged edits" button lack rounded corners. These are regular buttons, and they should have the standard 2px rounded corners that regular buttons have in all their edges.

Event Timeline

Catrope subscribed.

This is because these buttons are in a ButtonGroup, which normally puts them directly adjacent to each other (with no gap), so in that case the straight corners on the inside edges is a feature. However, in our code we manually added a gap, so now it looks weird.

Change 383963 had a related patch set uploaded (by Mooeypoo; owner: Mooeypoo):
[mediawiki/core@master] RCFilters: Use GroupWidget for grouping buttons and aggregating events

Change 383963 merged by jenkins-bot:
[mediawiki/core@master] RCFilters: Use GroupWidget for grouping buttons and aggregating events

Etonkovidova subscribed.

Checked in betalabs - the round corners are added.

Screen Shot 2017-10-13 at 3.38.29 PM.png (205×761 px, 24 KB)