Page MenuHomePhabricator
Create Task
Maniphest T169005

StructureTest::testUnitTestFileNamesEndWithTest() should not shell out
Closed, ResolvedPublic
Actions

Description

There's no reason for this test case to shell out, it can get the list of files and filter them in PHP itself.

Details

Related Changes in Gerrit:
SubjectAuthorRepoBranchLines +/-
StructureTest::testUnitTestFileNamesEndWithTest() should not shell outUmherirrendermediawiki/coremaster+19 -25
Customize query in gerrit

Event Timeline

Legoktm created this task.Jun 27 2017, 6:17 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 27 2017, 6:17 PM
Krinkle moved this task from Inbox to PHPUnit on the MediaWiki-Core-Tests board.Jul 7 2017, 5:01 AM
Legoktm added a project: good first task.Jul 26 2018, 8:56 PM
gerritbot subscribed.Sep 16 2018, 7:45 PM

Change 460769 had a related patch set uploaded (by Umherirrender; owner: Umherirrender):
[mediawiki/core@master] StructureTest::testUnitTestFileNamesEndWithTest() should not shell out

https://gerrit.wikimedia.org/r/460769

gerritbot added a project: Patch-For-Review.Sep 16 2018, 7:45 PM
Umherirrender claimed this task.Sep 16 2018, 8:03 PM
Umherirrender triaged this task as Medium priority.
gerritbot added a comment.Sep 19 2018, 5:37 PM

Change 460769 merged by jenkins-bot:
[mediawiki/core@master] StructureTest::testUnitTestFileNamesEndWithTest() should not shell out

https://gerrit.wikimedia.org/r/460769

Jdforrester-WMF closed this task as Resolved.Sep 19 2018, 5:38 PM
Jdforrester-WMF removed a project: Patch-For-Review.
ReleaseTaggerBot added a project: MW-1.32-notes (WMF-deploy-2018-09-25 (1.32.0-wmf.23)).Sep 19 2018, 6:00 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits