Page MenuHomePhabricator

Reconsider definition of "lead paragraph" on mobile view
Closed, InvalidPublic5 Story Points

Description

Background

The intro section of the mobile website (now appearing before the infobox) is currently defined as the first paragraph plus any ordered lists or unordered lists.

Problem statement

There are some edge cases, where this may not work.
We're yet to find examples so this may not actually be a problem.

Proposed solution

The definition of intro section should be as follows: the first paragraph plus any of the following items appearing prior to the second paragraph:

  • ordered lists
  • unordered lists
  • definition lists
  • formulas (math and chemistry)

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 28 2017, 12:03 PM

Please can we be careful with terminology. This is lead paragraph not section. Lead section is already defined as everything up to first heading...

Jdlrobson renamed this task from Lead section on mobile website uses incorrect definition of "lead" to Lead paragraph on mobile website uses incorrect definition of "lead".Jun 28 2017, 3:15 PM
Jdlrobson updated the task description. (Show Details)

Back on subject: why should it include definition lists? Do you have any examples?

ovasileva renamed this task from Lead paragraph on mobile website uses incorrect definition of "lead" to Intro section on mobile website defined incorrectly.Jun 28 2017, 6:45 PM
ovasileva updated the task description. (Show Details)
Jdlrobson renamed this task from Intro section on mobile website defined incorrectly to Reconsider definition of "lead paragraph" on mobile view.Jun 28 2017, 9:45 PM

With respect to https://phabricator.wikimedia.org/T169062#3387154
I should point out there is risk associated with changing the definition so unless we have a strong reason to do so... I wouldn't bother.

I say YAGNI it a lot and I think it applies here (http://wiki.c2.com/?YouArentGonnaNeedIt)

But unless your project is very different from mine, you already have too much to do right now. Doing more now is a very bad thing when you already have too much to do.

ovasileva updated the task description. (Show Details)Jul 4 2017, 4:18 PM

@ovasileva to add example for formulas

ovasileva updated the task description. (Show Details)Jul 4 2017, 4:23 PM
ovasileva set the point value for this task to 5.Jul 4 2017, 4:28 PM

I'm still waiting for answers on https://phabricator.wikimedia.org/T169062#3388821

There is a lot of risk associated with a 5 point task and I'm still not seeing why we are doing this.

@Jdlrobson - you mean in terms of the naming?

Firstly: let's check we are talking about the same thing.
This task is not about page previews it's about where we move the lead paragraph above the infobox.

https://en.wikipedia.org/wiki/Dioxygenyl is a bad and confusing example in this context. This page does not have an infobox. We do not run this code on pages without infoboxes. We only move paragraphs on pages with infoboxes.

I'm yet to see a real world example in a production wiki showing the status quo to be a problem. Do you know of any?

What I'm seeing here is a task recording that something is theoretically is not right. I understand that.
However, in practice in lieu of any counter-examples our existing code seems to be doing everything we need it to.
Despite this, we are proposing changing some stable code in a risky 5 pointer.
I have to ask why is this priority "normal" and why are we considering fixing this right now?

Jdlrobson updated the task description. (Show Details)Jul 5 2017, 7:02 PM
ovasileva closed this task as Invalid.May 10 2018, 3:00 PM