Make SpendenDumper export Sofortüberweisung payments
Closed, ResolvedPublic8 Story Points

Description

As a member of the fundraising team,
I want sofortüberweisung donations to be exported,
so that they can be processed by external provider

Acceptance Criteria:

  • SpendenDumper output contains sofortüberweisung payment type and transactionId

Background:
Spendendumper needs to be refactored for this. T169077 and T167886 are prerequisites for that.

gabriel-wmde moved this task from Backlog to Sprint ready on the WMDE-Fundraising-Tech board.
JeroenDeDauw moved this task from Todo to Doing on the WMDE-Fundraising-Sprint-11 board.
JeroenDeDauw removed JeroenDeDauw as the assignee of this task.Sep 17 2017, 5:43 PM
JeroenDeDauw added a subscriber: JeroenDeDauw.
JeroenDeDauw changed the point value for this task from 13 to 3.Sep 18 2017, 2:46 PM

Payment type is already included and we decided to not store the transactionId.

gabriel-wmde claimed this task.
gabriel-wmde changed the point value for this task from 3 to 13.

I would like to continue to refactor Spendendumper for roughly 13 points of complexity (or at least until Kai tells me to stop). My planned steps:

  • Have a simple configuration for the default fields and their order to output while retaining the "legacy" flags where custom field sets can be defined (done in https://github.com/wmde/fundraising-backend/pull/336)
  • Create value object for donation export parameters (created from command line flags)
  • Extract code exporting donations into a method (using the value object).
  • Extract export code into classes for each "domain object" (donation, membership, subscription)

But why? Why clean up this code and not something else? We can sink man-years into refactoring things we like to refactor... Doing this without anything beyond "I'd like to do this" while we have high prio tasks to complete is kinda odd to me.

Because for me, the point where I'm afraid to change anything in there has long been reached. In my opinion, SpendenDumper is the biggest technical debt we have at the moment and there are some changes coming where we need to touch it again. I'm aware of the other high prio tasks and promise to stop after 1-2 man days of coding.

gabriel-wmde removed gabriel-wmde as the assignee of this task.
gabriel-wmde updated the task description. (Show Details)
gabriel-wmde changed the point value for this task from 13 to 8.

IMO it'd have been better to deffer this cleanup till the point where we needed to touch the SpendenDumper. I'd also be more happy if this was a team decision. Perhaps it was discussed with Kai and Pablo without me knowing about it, in which case I am somewhat less grump about it.

gabriel-wmde closed this task as Resolved.Wed, Sep 27, 3:50 PM
gabriel-wmde claimed this task.

Deployed to production.