Page MenuHomePhabricator
Create Task
Maniphest T169117

New "Join Wikipedia" and "Log in" banners are light in dark mode
Closed, ResolvedPublic
Actions

Assigned To
Dbrant
Authored By
• Mholloway
Jun 28 2017, 4:42 PM
Tags
Referenced Files
F8994899: main-MainActivity-08092017122342.png
Aug 9 2017, 10:27 AM
F8994896: main-MainActivity-08092017122336.png
Aug 9 2017, 10:27 AM
F8548364: Screenshot_20170628-124011.png
Jun 28 2017, 4:42 PM
F8548363: Screenshot_20170628-124006.png
Jun 28 2017, 4:42 PM
Subscribers
ABorbaWMF
Aklapper
gerritbot
• Mholloway
RHo

Description

Screenshot_20170628-124006.png (2×1 px, 82 KB)

Screenshot_20170628-124011.png (2×1 px, 118 KB)

Details

ProjectBranchLines +/-Subject
apps/android/wikipediamaster+25 -34Fix login / create account onboarding colors for dark mode.
Customize query in gerrit

Related Objects
Search...

Event Timeline

• Mholloway created this task.Jun 28 2017, 4:42 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 28 2017, 4:42 PM
RHo mentioned this in T95080: Update colors in Dark theme to meet color contrast requirements.Jul 5 2017, 3:35 PM
RHo added a parent task: T95080: Update colors in Dark theme to meet color contrast requirements.
gerritbot added a subscriber: gerritbot.Jul 13 2017, 5:56 PM

Change 365073 had a related patch set uploaded (by Dbrant; owner: Dbrant):
[apps/android/wikipedia@master] Fix login / create account onboarding colors for dark mode.

https://gerrit.wikimedia.org/r/365073

gerritbot added a project: Patch-For-Review.Jul 13 2017, 5:56 PM
gerritbot added a comment.Jul 14 2017, 3:09 PM

Change 365073 merged by jenkins-bot:
[apps/android/wikipedia@master] Fix login / create account onboarding colors for dark mode.

https://gerrit.wikimedia.org/r/365073

• NHarateh_WMF edited projects, added Wikipedia-Android-App-Backlog (Android-app-release-v2.7.20x-Dookie💩); removed Wikipedia-Android-App-Backlog.Jul 14 2017, 3:12 PM
Restricted Application edited projects, added Wikipedia-Android-App-Backlog; removed Wikipedia-Android-App-Backlog (Android-app-release-v2.7.20x-Dookie💩). · View Herald TranscriptJul 14 2017, 3:12 PM
• NHarateh_WMF edited projects, added Wikipedia-Android-App-Backlog (Android-app-release-v2.7.20x-Dookie💩); removed Wikipedia-Android-App-Backlog.Jul 14 2017, 3:13 PM
• NHarateh_WMF moved this task from To Do to Design Signoff on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.20x-Dookie💩) board.
RHo moved this task from Design Signoff to QA Signoff on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.20x-Dookie💩) board.Aug 9 2017, 10:27 AM
RHo added a subscriber: RHo.

LGTM.

Login screen in dark mode
main-MainActivity-08092017122336.png (1×1 px, 75 KB)
Create account in dark mode
main-MainActivity-08092017122342.png (1×1 px, 101 KB)

Tested with Nexus 5 (Android 6.0.1) on Wikipedia v2.6.200-alpha-2017-08-08

ABorbaWMF moved this task from QA Signoff to Ready for Signoff on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.20x-Dookie💩) board.Aug 10 2017, 8:59 PM
ABorbaWMF added a subscriber: ABorbaWMF.

Tested on a Nexus 4 with Android 5.1 and a Pixel with Android 7.1.1

Looks good

Dbrant moved this task from Ready for Signoff to Done on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.20x-Dookie💩) board.Aug 24 2017, 5:51 PM
Dbrant closed this task as Resolved.Aug 24 2017, 5:53 PM
Dbrant claimed this task.
Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL