Page MenuHomePhabricator
Create Task
Maniphest T169288

Properly handle malformed curl results
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

Currently, if a curl result is bad, it returns a 500 error. We should be able to handle these errors in all instances, and return default values. This may require try/catch blocks.

Event Timeline

Matthewrbowker created this task.Jun 30 2017, 2:17 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 30 2017, 2:17 AM
Matthewrbowker moved this task from Backlog to Working on the XTools board.Jul 11 2017, 8:43 PM
Matthewrbowker moved this task from Working to General / other on the XTools board.Jul 17 2017, 9:35 PM
Matthewrbowker claimed this task.Jul 26 2017, 4:59 PM
Matthewrbowker triaged this task as Low priority.
Matthewrbowker moved this task from General / other to Working on the XTools board.
Matthewrbowker added a project: User-Matthewrbowker.
Matthewrbowker moved this task from Inbox to Working on the User-Matthewrbowker board.
Matthewrbowker closed this task as Resolved.Aug 8 2017, 9:27 PM
Matthewrbowker moved this task from Working to Pending deployment on the XTools board.
Matthewrbowker set the point value for this task to 1.

I'm going to close this now, I made a few changes within API helper to catch exceptions based on "\Exception" - e.g. https://github.com/x-tools/xtools/blob/rfa/src/AppBundle/Helper/ApiHelper.php#L345 This is working in my testing.

This will be merged when https://github.com/x-tools/xtools/pull/67 is merged. Any additional errors can re-open this task.

Matthewrbowker moved this task from Working to Complete on the User-Matthewrbowker board.Aug 8 2017, 9:27 PM
Matthewrbowker moved this task from Complete to Accepted on the User-Matthewrbowker board.Aug 8 2017, 10:11 PM
MusikAnimal moved this task from Pending deployment to Pending Review on the XTools board.Aug 9 2017, 3:22 PM
Kizule moved this task from Pending Review to Complete on the XTools board.Sep 20 2017, 5:38 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL