Page MenuHomePhabricator
Create Task
Maniphest T169379

Update and adopt new special page template for remaining special pages (Contributions, Nearby, History and Watchlist)
Closed, ResolvedPublic
Actions

Assigned To
None
Authored By
• Nirzar
Jun 30 2017, 9:56 PM
Tags
Referenced Files
F13952821: Screen Shot 2018-02-22 at 9.27.57 AM.png
Feb 22 2018, 5:29 PM
F10301396: Screen Shot 2017-10-18 at 4.43.36 PM.png
Oct 18 2017, 11:49 PM
F10301408: Screen Shot 2017-10-18 at 4.48.01 PM.png
Oct 18 2017, 11:49 PM
F10301400: Screen Shot 2017-10-18 at 4.44.53 PM.png
Oct 18 2017, 11:49 PM
F10301395: Screen Shot 2017-10-18 at 4.43.24 PM.png
Oct 18 2017, 11:49 PM
F10301394: Screen Shot 2017-10-18 at 4.43.14 PM.png
Oct 18 2017, 11:49 PM
F8583947: Simulator Screen Shot Jun 30, 2017, 2.57.02 PM.png
Jun 30 2017, 9:57 PM
F8583938: Simulator Screen Shot Jun 30, 2017, 2.54.15 PM.png
Jun 30 2017, 9:56 PM
View All 9 Files
Subscribers
Aklapper
Jdlrobson
• Nirzar
ovasileva

Description

Problem

Refer to the parent EPIC for the problem statement

This task is about adapting the template for settings page on mobile frontend.

Mock

Existing

Simulator Screen Shot Jun 30, 2017, 2.57.02 PM.png (1×750 px, 109 KB)

Proposed

settings-page.png (1×750 px, 110 KB)

Note: The proposed mock does not contain pieces from T67079: [Epic] Show what features are included in Beta

Acceptance criteria

  • Code is kept in a feature branch that is enabled on reading web staging to allow us to incrementally update the special pages
  • The settings page uses common special page template
  • The title and subtitle says "Settings" and "Reading preferences"

Developer notes

This is mostly removing CSS in skinStyles/mobile.special.styles
Note all the layouts for special pages are closely tied together. We'll make use of a feature
branch to avoid breakage:

Screen Shot 2017-10-18 at 4.43.14 PM.png (330×1 px, 35 KB)

Screen Shot 2017-10-18 at 4.43.24 PM.png (335×1 px, 39 KB)

Screen Shot 2017-10-18 at 4.43.36 PM.png (342×1 px, 67 KB)

Screen Shot 2017-10-18 at 4.44.53 PM.png (347×1 px, 36 KB)

Screen Shot 2017-10-18 at 4.48.01 PM.png (341×1 px, 41 KB)

Related: T147722

Related Objects
Search...

Event Timeline

• Nirzar created this task.Jun 30 2017, 9:56 PM
• Nirzar updated the task description. (Show Details)
• Nirzar moved this task from Incoming to Design on the Web-Team-Backlog-Archived board.Jun 30 2017, 11:25 PM
• Nirzar edited projects, added Web-Team-Backlog-Archived (Design); removed Web-Team-Backlog-Archived.
• Nirzar moved this task from Needs analysis to Next up on the Web-Team-Backlog-Archived (Design) board.
ovasileva subscribed.Jul 3 2017, 5:49 PM
• Nirzar moved this task from Backlog to UI Standardization on the Design (RW-Design-Debt) board.Jul 3 2017, 10:13 PM
• Nirzar mentioned this in T109364: Promote fontchanger to stable (in feature branch).Jul 7 2017, 7:12 PM
• Nirzar moved this task from Next up to Designing/discussing right now on the Web-Team-Backlog-Archived (Design) board.Jul 7 2017, 10:55 PM
• Nirzar moved this task from Design to Triaged but Future on the Web-Team-Backlog-Archived board.Sep 11 2017, 10:53 PM
• Nirzar edited projects, added Web-Team-Backlog-Archived; removed Web-Team-Backlog-Archived (Design).
ovasileva moved this task from Triaged but Future to Upcoming on the Web-Team-Backlog-Archived board.Oct 11 2017, 7:40 PM
ovasileva moved this task from Upcoming to Triaged but Future on the Web-Team-Backlog-Archived board.Oct 17 2017, 12:21 PM
Jdlrobson added a project: MinervaNeue.Oct 18 2017, 11:38 PM
Jdlrobson renamed this task from Adopt new special page template for Special:MobileOptions to Adopt new special page template for special pages (Contributions, MobileOptions, History and Watchlist).Oct 18 2017, 11:48 PM
Jdlrobson renamed this task from Adopt new special page template for special pages (Contributions, MobileOptions, History and Watchlist) to Adopt new special page template for special pages (Contributions, MobileOptions, Nearby, History and Watchlist).
Jdlrobson updated the task description. (Show Details)
Jdlrobson updated the task description. (Show Details)Oct 18 2017, 11:54 PM
Jdlrobson mentioned this in T169369: Change font size controls to use small, regular, large and extra large buckets.Oct 30 2017, 7:42 PM
Jdlrobson moved this task from Backlog to TODO on the MinervaNeue board.Oct 31 2017, 5:44 PM
Jdlrobson updated the task description. (Show Details)Nov 7 2017, 8:10 PM
Jdlrobson updated the task description. (Show Details)
ovasileva added a comment.Nov 21 2017, 5:32 PM

@Nirzar - after we do the changes in T180095: Update the title alignment for special pages perhaps we should skip this and change the acceptance criteria for the epic itself?

Jdlrobson edited projects, added Web-Team-Backlog-Archived (Design); removed Web-Team-Backlog-Archived.Nov 21 2017, 5:32 PM
• Nirzar added a comment.Nov 21 2017, 5:33 PM

@ovasileva sounds good!

Jdlrobson renamed this task from Adopt new special page template for special pages (Contributions, MobileOptions, Nearby, History and Watchlist) to Update and adopt new special page template for remaining special pages (Contributions, Nearby, History and Watchlist).Nov 28 2017, 10:23 PM
Jdlrobson added a subtask: T120520: [Story] make it easier to understand what Special:Nearby is.
Jdlrobson mentioned this in T180095: Update the title alignment for special pages.
ovasileva added a project: Mobile-Web-Settings.Dec 7 2017, 7:32 PM
• Nirzar closed this task as Resolved.Feb 21 2018, 6:16 PM

This is now done as part of settings work!

Jdlrobson subscribed.Feb 22 2018, 5:29 PM

@Nirzar is it?
There are tasks relating to Nearby - T120520 and T94297. I'm fine tracking these as bugs but I'm pretty sure there are other untracked bugs - for instance how things appear in tablet mode - it seems odd on the eye to me to center my username like so:

Screen Shot 2018-02-22 at 9.27.57 AM.png (253×1 px, 35 KB)

Would you mind making sure we've captured all the remaining problems with special pages in the backlog?

• Nirzar added a comment.Feb 22 2018, 8:13 PM

Would you mind making sure we've captured all the remaining problems with special pages in the backlog?

all of the improvements on top of updating to the _current_ state of special page can be under
https://phabricator.wikimedia.org/T169162

we can create subtasks for each of the cases. but we kinda abandoned the idea of creating a template, so adopting is lead by use-cases than template based approach. e.g. next we would build tabs and then apply tabs on particular pages. instead of fixing userpages completely.

• Phabricator_maintenance moved this task from Design to 2017-18 Q3 on the Web-Team-Backlog-Archived board.Mar 7 2018, 4:42 AM
• Phabricator_maintenance edited projects, added Web-Team-Backlog-Archived; removed Web-Team-Backlog-Archived (Design).
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits