Fix "JQMIGRATE: jQuery.fn.unbind() is deprecated" in WikiLove
Closed, ResolvedPublic
Actions

Description

Steps

View https://en.wikipedia.beta.wmflabs.org/wiki/Map
Observe in the console:

JQMIGRATE: jQuery.fn.unbind() is deprecated

Source

From $wikiLoveLink.unbind('click'); (ext.wikiLove.core) at https://github.com/wikimedia/mediawiki-extensions-WikiLove/blob/bab50878ffe1bfec77119d6609531d849f68b9ad/resources/ext.wikiLove.core.js#L838

Documentation

Release notes:
https://jquery.com/upgrade-guide/3.0/#deprecated-bind-and-delegate

Migration legend:
https://github.com/jquery/jquery-migrate/blob/e967c3b9/warnings.md#jqmigrate-jqueryfnunbind-is-deprecated

Details

	Project	Branch	Lines +/-	Subject
	mediawiki/extensions/WikiLove	master	+1 -1	Fix "JQMIGRATE: jQuery.fn.unbind() is deprecated" in WikiLove

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved		Krinkle	T169385 jQuery 3 migration warnings
		Resolved		Catrope	T169387 Fix "JQMIGRATE: jQuery.fn.unbind() is deprecated" in WikiLove

Event Timeline

Krinkle created this task.Jul 1 2017, 1:12 AM

Restricted Application added a project: Collaboration-Team-Triage. · View Herald TranscriptJul 1 2017, 1:12 AM

Change 371037 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/extensions/WikiLove@master] Fix "JQMIGRATE: jQuery.fn.unbind() is deprecated" in WikiLove

https://gerrit.wikimedia.org/r/371037

gerritbot added a project: Patch-For-Review.Aug 10 2017, 2:07 PM

Catrope closed this task as Resolved.Aug 10 2017, 2:09 PM

Catrope claimed this task.

Change 371037 merged by jenkins-bot:
[mediawiki/extensions/WikiLove@master] Fix "JQMIGRATE: jQuery.fn.unbind() is deprecated" in WikiLove

https://gerrit.wikimedia.org/r/371037

ReleaseTaggerBot added a project: MW-1.30-release-notes (WMF-deploy-2017-08-15 (1.30.0-wmf.14)).Aug 10 2017, 3:00 PM

Krinkle removed a project: Patch-For-Review.Aug 11 2017, 2:30 PM

Fix "JQMIGRATE: jQuery.fn.unbind() is deprecated" in WikiLoveClosed, ResolvedPublicActions