Page MenuHomePhabricator

Scenario: Successful edit on page without languages shows no language button fails and is blocking merges
Closed, DeclinedPublic

Description

Right now it's impossible to merge any change in master due to a browser test failure on:
cucumber features/editor_wikitext_saving.feature:8 # Scenario: Successful edit on page without languages shows no language button [bug 63675]

Event Timeline

Actually seems like this was a blip and now they are passing again.. I'm too eager to create tasks :)

Our tests are actually super flaking (getting worse probably due to the lack of Ruby browser test support) but they never block merging (usually a few pokes at Jenkins and it eventually passes) :-/. I've managed to merge your task. Sorry about any confusion that may have caused I think we're becoming oblivious to it! :/

We're porting them to Node.js to hopefully add some stability. That's tracked in T190710 if you are interesting in following along!

@Jdlrobson I think this test failing occasionally might be an async issue? like the button might not be there before the test is executed?

I think this is a timing issue, but it's not just this test there are other tests that fail occasionally too. These are painful and we're trying our hardest to move to T190710 but it's proving tricky.

I'd advise ignoring mwskin-mw-selenium-jessie in the mean time. It doesn't seem to impact merges that job seems to always work fine on merges - I'm not sure why. There may be issues somewhere else in the unmaintained Ruby stack.