Page MenuHomePhabricator

Can't close Media Viewer with Minerva skin turned on
Closed, ResolvedPublic

Description

Visit https://he.wikipedia.org/wiki/%D7%A7%D7%95%D7%A8%D7%91%D7%9F_%D7%A4%D7%A1%D7%97?useskin=minerva on desktop and open an image. Media Viewer opens correctly. When you close it, you end up with the mobile site's image viewer, which probably loaded behind Media Viewer. And you get stuck, because that can't be closed.

It seems like the mobile image viewer should just be disabled with Minerva as a skin, as Media Viewer seems to work fine.

Details

Related Gerrit Patches:

Event Timeline

Gilles created this task.Jul 4 2017, 12:06 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 4 2017, 12:06 PM
Jdlrobson added a subscriber: MarkTraceur.

@MarkTraceur if I submit a patch to MobileFrontend/Minerva can you review/merge ?

I quickly tried said url & opened an image and all I saw was MMV, which seemed to close just fine without side effects.
But sure, we can review a patch!

Change 366482 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/skins/MinervaNeue@master] Don't show ImageOverlay in desktop mode - delegate to multimedia viewer

https://gerrit.wikimedia.org/r/366482

I saw was MMV, which seemed to close just fine without side effects.

try again. Pretty easy to replicate. Do you have MobileFrontend installed as well?
The above patch fixes the problem.

I was trying on the link in the description, on hewiki, but somehow it didn't happen for me. Either way, that patch looks fine!

Change 366482 merged by jenkins-bot:
[mediawiki/skins/MinervaNeue@master] Don't show ImageOverlay in desktop mode - delegate to multimedia viewer

https://gerrit.wikimedia.org/r/366482

Bug has been fixed so adding to sprint so it can go through sign off. If more work is needed please throw it out of the sprint.