Page MenuHomePhabricator
Create Task
Maniphest T169639

Make it possible to add Senses to the Lexeme
Closed, ResolvedPublic
Actions

Description

User should be able to add a new Sense to the Lexeme.

When adding a new Sense, user should be able to specify a gloss of a new sense in at least one language.

Acceptance criteria:

  • At the end of Senses section of the Lexeme there is a button to add a new Sense.
  • The button opens a form to enter gloss(es)
  • One saved, a new sense, including just specified glosses is displayed at the end of the Sense list
  • When the lexeme page is reloaded, changes are gone.

Details

ProjectBranchLines +/-Subject
mediawiki/extensions/WikibaseLexememaster+22 -2Add browser test for adding senses.
mediawiki/extensions/WikibaseLexememaster+137 -271Make GlossWidget controlled by jquery.wikibase.senseview
mediawiki/extensions/WikibaseLexememaster+20 -5Move empty gloss addition logic to GlossWidget
mediawiki/extensions/WikibaseLexememaster+49 -12Make it possible to add Senses to a Lexeme
Customize query in gerrit

Related Objects
Search...

Event Timeline

WMDE-leszek created this task.Jul 4 2017, 2:09 PM
WMDE-leszek moved this task from Proposed to Backlog on the Wikidata-Former-Sprint-Board board.
Jakob_WMDE claimed this task.Jul 6 2017, 12:45 PM
Jakob_WMDE moved this task from Backlog to Doing on the Wikidata-Former-Sprint-Board board.
gerritbot added a subscriber: gerritbot.Jul 6 2017, 12:48 PM

Change 363584 had a related patch set uploaded (by Jakob; owner: Jakob):
[mediawiki/extensions/WikibaseLexeme@master] [WIP] Make it possible to add Senses to a Lexeme.

https://gerrit.wikimedia.org/r/363584

gerritbot added a project: Patch-For-Review.Jul 6 2017, 12:48 PM
Jakob_WMDE mentioned this in rEWLE4a34626a6b70: [WIP] Make it possible to add Senses to a Lexeme..Jul 6 2017, 12:49 PM
• Aleksey_WMDE mentioned this in rEWLE021ff3b5a2db: Make it possible to add Senses to a Lexeme.Jul 6 2017, 2:02 PM
gerritbot added a comment.Jul 6 2017, 3:25 PM

Change 363624 had a related patch set uploaded (by Aleksey Bekh-Ivanov (WMDE); owner: Aleksey Bekh-Ivanov (WMDE)):
[mediawiki/extensions/WikibaseLexeme@master] Move empty gloss addition logic to GlossWidget

https://gerrit.wikimedia.org/r/363624

gerritbot added a comment.Jul 6 2017, 3:26 PM

Change 363625 had a related patch set uploaded (by Aleksey Bekh-Ivanov (WMDE); owner: Aleksey Bekh-Ivanov (WMDE)):
[mediawiki/extensions/WikibaseLexeme@master] Make GlossWidget controlled by jquery.wikibase.senseview

https://gerrit.wikimedia.org/r/363625

• Aleksey_WMDE mentioned this in rEWLE933b070c40c1: Move empty gloss addition logic to GlossWidget.Jul 6 2017, 3:26 PM
• Aleksey_WMDE mentioned this in rEWLE2f0adcd6a33f: Make GlossWidget controlled by jquery.wikibase.senseview.
• Aleksey_WMDE mentioned this in rEWLEd5c4b577180e: Make GlossWidget controlled by jquery.wikibase.senseview.Jul 6 2017, 4:23 PM
gerritbot added a comment.Jul 7 2017, 8:47 AM

Change 363584 merged by jenkins-bot:
[mediawiki/extensions/WikibaseLexeme@master] Make it possible to add Senses to a Lexeme

https://gerrit.wikimedia.org/r/363584

gerritbot added a comment.Jul 7 2017, 8:47 AM

Change 363624 merged by jenkins-bot:
[mediawiki/extensions/WikibaseLexeme@master] Move empty gloss addition logic to GlossWidget

https://gerrit.wikimedia.org/r/363624

• Aleksey_WMDE claimed this task.Jul 11 2017, 10:12 AM
• Aleksey_WMDE moved this task from Doing to Review on the Wikidata-Former-Sprint-Board board.
• Aleksey_WMDE added a subscriber: Jakob_WMDE.
WMDE-leszek mentioned this in rEWLE72f0df7de21c: Make GlossWidget controlled by jquery.wikibase.senseview.Jul 11 2017, 11:13 AM
• Aleksey_WMDE mentioned this in rEWLEa50a6fcee03e: Make GlossWidget controlled by jquery.wikibase.senseview.Jul 11 2017, 11:51 AM
gerritbot added a comment.Jul 11 2017, 11:53 AM

Change 364419 had a related patch set uploaded (by Jakob; owner: Jakob):
[mediawiki/extensions/WikibaseLexeme@master] Add browser test for adding senses.

https://gerrit.wikimedia.org/r/364419

Jakob_WMDE mentioned this in rEWLE0badcc077ea1: Add browser test for adding senses..Jul 11 2017, 11:54 AM
• Aleksey_WMDE mentioned this in rEWLE5e0b9eb32c3c: Make GlossWidget controlled by jquery.wikibase.senseview.Jul 11 2017, 12:05 PM
gerritbot added a comment.Jul 11 2017, 12:36 PM

Change 363625 merged by jenkins-bot:
[mediawiki/extensions/WikibaseLexeme@master] Make GlossWidget controlled by jquery.wikibase.senseview

https://gerrit.wikimedia.org/r/363625

gerritbot added a comment.Jul 11 2017, 3:03 PM

Change 364419 merged by jenkins-bot:
[mediawiki/extensions/WikibaseLexeme@master] Add browser test for adding senses.

https://gerrit.wikimedia.org/r/364419

WMDE-leszek moved this task from Review to Done on the Wikidata-Former-Sprint-Board board.Jul 11 2017, 3:04 PM
Ladsgroup moved this task from incoming to in progress on the Wikidata board.Jul 20 2017, 9:27 AM
• Aleksey_WMDE closed this task as Resolved.Jul 25 2017, 2:52 PM
Restricted Application added a subscriber: PokestarFan. · View Herald TranscriptJul 25 2017, 2:52 PM
Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL