[BUG] iOS simulator : hideRedLinks has unsupported JavaScript code for Safari 9.3
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	yangand
	Jul 4 2017, 4:01 PM

Project Tags

Referenced Files

	F8617581: Simulator Screen Shot 4 июля 2017 г., 18.12.44.png
	Jul 4 2017, 4:01 PM

Subscribers

Description

How many times were you able to reproduce it?

Everytime when I run wikipedia-ios in iOS simulator 9.3 (10.3 works well)

Steps to reproduce

build Wikipedia target and run it in iOS simulator iPhone 5 - iOS 9.3
open any article with leading image
image describing the article is absent at top of the page

Expected results

it should be an image in top of article
really works well in iOS simulator 10.3.1

Actual results

no image

Screenshots

Simulator Screen Shot 4 июля 2017 г., 18.12.44.png (640×1,136 px, 79 KB)

Environments observed

App version: 5.5.1
OS versions: macOS 10.12 iOS simulator sdk 9.3
Device model: simulator iphone 5
Device language: en

Regression?

I don't know

Reason

redLinkAnchorsInContent returns NodeList and applies forEach method for it, but it looks like forEach is supported for NodeList in 10+ version of Safari (webkit) (https://developer.mozilla.org/en/docs/Web/API/NodeList#Browser_compatibility)

not working

redLinkAnchorsInContent(content).forEach

fix

Array.from(redLinkAnchorsInContent(content)).forEach

Related Objects

Mentioned In: rAPIOSc6e049c1c3b5: Merge pull request #1598 from wikimedia/bug/ios-9-article-loading/T169660
rAPIOS35f24f4d97b6: Merge branch 'develop' into bug/ios-9-article-loading/T169660
rAPIOS34ffbb8305db: Merge branch 'develop' into bug/ios-9-article-loading/T169660

Event Timeline

yangand created this task.Jul 4 2017, 4:01 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 4 2017, 4:01 PM

yangand renamed this task from [BUG] hideRedLinks has unsupported JavaScript code for Safari 9.3 to [BUG] iOS simulator : hideRedLinks has unsupported JavaScript code for Safari 9.3.Jul 4 2017, 4:02 PM

@Mhurd, you may want to confirm that Array.from() is polyfilled too.

Mhurd claimed this task.Jul 5 2017, 8:40 PM

@ABorbaWMF can you test the current store version on your 9.x device? If this is happening in the wild, we should cut and ship a 5.5.2.

• JMinor triaged this task as High priority.Jul 5 2017, 9:46 PM

https://github.com/wikimedia/wikipedia-ios/pull/1598

This was the page library patch which fixed the underlying issue: https://github.com/wikimedia/wikimedia-page-library/pull/48

@yangand thanks for catching and documenting this!!!

Diffusion mentioned this in rAPIOS34ffbb8305db: Merge branch 'develop' into bug/ios-9-article-loading/T169660.Jul 5 2017, 11:07 PM

JoeWalsh mentioned this in rAPIOS35f24f4d97b6: Merge branch 'develop' into bug/ios-9-article-loading/T169660.Jul 6 2017, 10:42 AM

@Mhurd @JMinor I am able to repro on develop, but not on the 5.5.1 branch. The regression was introduced after the 5.5.0 & 5.5.1 releases split off of develop.

JoeWalsh mentioned this in rAPIOSc6e049c1c3b5: Merge pull request #1598 from wikimedia/bug/ios-9-article-loading/T169660.Jul 6 2017, 2:37 PM

Thanks @JoeWalsh I wondered, as this ticket is not version tagged and I don't recall it going through QA or sign-off

Mhurd added a project: iOS-app-v5.6.0-Goat-On-A-Train.Jul 6 2017, 6:42 PM

Mhurd moved this task from Tasks from Product Backlog to Needs Acceptance Criteria on the iOS-app-v5.6.0-Goat-On-A-Train board.

Mhurd moved this task from Needs Acceptance Criteria to Needs Testing Criteria on the iOS-app-v5.6.0-Goat-On-A-Train board.

• JMinor lowered the priority of this task from High to Medium.Jul 6 2017, 10:47 PM

• JMinor moved this task from Needs Triage to Engineering Backlog on the Wikipedia-iOS-App board.

@JMinor I tried with the store app 5.5.1 (1164) on the iPhone 4 with iOS 9.3 and I saw lead images for all the articles I tapped. I noticed it took a longish amount of time for the image to load. I also noticed in the screenshot of the original bug it looks like the article is still loading. Let me know if there's anything else I should try.

• Niedzielski moved this task from Open to Backlog on the wikimedia-page-library board.Jul 14 2017, 1:34 AM

Mhurd moved this task from Needs Testing Criteria to Ready for PM Signoff on the iOS-app-v5.6.0-Goat-On-A-Train board.Jul 15 2017, 2:01 AM

• JMinor closed this task as Resolved.Aug 3 2017, 12:23 AM

[BUG] iOS simulator : hideRedLinks has unsupported JavaScript code for Safari 9.3Closed, ResolvedPublicActions