Thumbor can't render some animated GIFs properly
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	• Gilles
	Jul 5 2017, 6:43 AM

Description

Old render by Mediawiki: https://upload.wikimedia.org/wikipedia/commons/thumb/9/92/SCARA_left.gif/180px-SCARA_left.gif

Render by Thumbor: https://upload.wikimedia.org/wikipedia/commons/thumb/9/92/SCARA_left.gif/200px-SCARA_left.gif

I'm going to bet that this is due to this particular GIF being made of very fine lines.

I believe Thumbor doesn't use the same conversion tool that Mediawiki used to for animated GIFs. However, that particular page has some thumbnails that Mediawiki couldn't render before due to OOM: T63711: Out of memory for some GIF thumbnail versions of animated GIF images on Commons (exceeding the 50 MP limit?) that Thumbor "can" render now, so ideally we'd want gifsicle (what Thumbor uses) to behave properly.

More can be found on this page:

https://commons.wikimedia.org/w/index.php?title=Special%3AListFiles&limit=500&user=Pasimi&ilshowall=1

Details

	Subject	Repo	Branch	Lines +/-
	Upgrade to 1.0	operations/debs/python-thumbor-wikimedia	master	+931 -5
	Make Thumbor GIF engine configuration match production	mediawiki/vagrant	master	+5 -4

Customize query in gerrit

Revisions and Commits

rTHMBREXT Thumbor Plugins
	Restricted Differential Revision	rTHMBREXTcc3617eb28cb Fix support for GIFs with very few colors

Related Objects

Mentioned Here: T63711: Out of memory for some GIF thumbnail versions of animated GIF images on Commons (exceeding the 50 MP limit?)

Event Timeline

• Gilles created this task.Jul 5 2017, 6:43 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 5 2017, 6:43 AM

• Gilles triaged this task as High priority.Jul 5 2017, 6:43 AM

Krinkle subscribed.Jul 6 2017, 5:07 AM

• Gilles moved this task from Inbox, needs triage to To-do: Goals prioritized current Quarter on the Performance-Team board.Jul 6 2017, 7:27 PM

Change 364234 had a related patch set uploaded (by Gilles; owner: Gilles):
[mediawiki/vagrant@master] Make Thumbor GIF engine configuration match production

https://gerrit.wikimedia.org/r/364234

gerritbot added a project: Patch-For-Review.Jul 10 2017, 4:06 PM

• Gilles added a revision: Restricted Differential Revision.Jul 10 2017, 4:23 PM

Change 364234 merged by jenkins-bot:
[mediawiki/vagrant@master] Make Thumbor GIF engine configuration match production

https://gerrit.wikimedia.org/r/364234

• Gilles added a commit: rTHMBREXTcc3617eb28cb: Fix support for GIFs with very few colors.Jul 12 2017, 12:44 PM

Change 364752 had a related patch set uploaded (by Gilles; owner: Gilles):
[operations/debs/python-thumbor-wikimedia@master] Upgrade to 1.0

https://gerrit.wikimedia.org/r/364752

Change 364752 merged by Filippo Giunchedi:
[operations/debs/python-thumbor-wikimedia@master] Upgrade to 1.0