Page MenuHomePhabricator
Create Task
Maniphest T169757

Improve usability of "download as pdf" page
Closed, InvalidPublic
Actions

Description

Background

Currently, when a user selects to download a page in two-column format, they are redirected to a "rendering finished" page which has a button for downloading the PDF (https://en.wikipedia.org/w/index.php?title=Special:Book&bookcmd=rendering&return_to=Main+Page&collection_id=f76862132045e12d1f62c3c065c54af7f3f8b2b7&writer=rdf2latex&is_cached=1)

For the electron option, we currently have no such page and selecting "download as PDF" automatically generated the PDF

We would like to investigate whether it's worth it to have a similar page for the updated PDF renderer. In the future, this page may also contain setting and customization for the PDF.

Acceptance criteria

Redesign download as pdf page to account for:

  • Rendering updates (currently done by percentage)
  • Rendering completion and download button
  • Page must contain size (if available)
  • Page must contain article name
  • Remove old page (selections screen)
  • Update instrumentation
  • Feature flag and add to beta cluster

Prototype

https://wikimedia.invisionapp.com/share/MSD8GDQBH#/screens/250732064

Related Objects
Search...

Event Timeline

ovasileva created this task.Jul 5 2017, 3:22 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 5 2017, 3:22 PM
ovasileva triaged this task as High priority.Jul 5 2017, 3:22 PM
• Nirzar moved this task from Needs analysis to Next up on the Web-Team-Backlog (Design) board.Jul 7 2017, 10:55 PM
• Nirzar moved this task from Next up to Designing/discussing right now on the Web-Team-Backlog (Design) board.Jul 10 2017, 6:12 PM
• Nirzar renamed this task from Redesign download as pdf page to Improve usability of "download as pdf" page .Jul 21 2017, 2:11 AM
ovasileva updated the task description. (Show Details)Jul 21 2017, 10:49 AM
ovasileva added a parent task: T171956: Allow PDF rendering to be triggered only by electron for single-article PDFs.Aug 25 2017, 10:30 AM
• Nirzar added a comment.Aug 28 2017, 9:28 PM

Like on mobile[1], we could have a step between clicking "download as pdf" and trigger the file download.

  1. Tap on "download as PDF" link in left sidebar.
  2. instead of going to a different page it opens a modal window
  3. shows minimal info about the pdf and a way to download
  4. in future we can add the pdf options such as "include images" "dark mode" "1 col 2 col" in this same modal window.

Prototype

https://wikimedia.invisionapp.com/share/MSD8GDQBH#/250732064_land

[1] https://phabricator.wikimedia.org/T163472

• Nirzar added a comment.Aug 28 2017, 9:28 PM

@ovasileva see if this design ^ works, I can update the description after your okay.

ovasileva added a comment.Aug 29 2017, 12:05 PM

@Nirzar - looks good

ovasileva mentioned this in T171956: Allow PDF rendering to be triggered only by electron for single-article PDFs.Aug 30 2017, 5:45 PM
ovasileva added a project: Proton.
ovasileva moved this task from Triage to Needs Analysis on the Proton board.
ovasileva moved this task from Needs Analysis to Backlog on the Proton board.Sep 6 2017, 6:58 PM
• Nirzar removed • Nirzar as the assignee of this task.Sep 6 2017, 10:10 PM
• Nirzar moved this task from Design to Triaged but Future on the Web-Team-Backlog board.
• Nirzar edited projects, added Web-Team-Backlog; removed Web-Team-Backlog (Design).
• Nirzar added a subscriber: • Nirzar.
ovasileva moved this task from Triaged but Future to Upcoming on the Web-Team-Backlog board.Sep 12 2017, 12:12 PM
ovasileva updated the task description. (Show Details)Sep 12 2017, 4:23 PM
ovasileva updated the task description. (Show Details)Sep 12 2017, 4:26 PM
ovasileva updated the task description. (Show Details)
ovasileva updated the task description. (Show Details)Sep 12 2017, 4:28 PM
• Nirzar updated the task description. (Show Details)Sep 12 2017, 4:29 PM
ovasileva updated the task description. (Show Details)Sep 12 2017, 4:30 PM
ovasileva updated the task description. (Show Details)EditedSep 12 2017, 4:32 PM

@Nirzar - what should we do for non-JS users. It seems that we could either:

  • not display this as a modal and send everyone to the page as previously but redesign the page
  • use the old page for non-JS users and present the same info
  • have non-JS users print automatically on clicking "download as PDF" and show the modal to everyone else
ovasileva added a comment.Sep 12 2017, 4:34 PM

potentially split this up into:

  • make changes to the old page (potentially delete)
  • feature-flag and deploy to beta cluster
ovasileva added a comment.Sep 12 2017, 4:35 PM

@Nirzar - we also will not be aware of PDF size

ovasileva added a comment.Sep 13 2017, 4:42 PM

non-JS browsers will use the page created in T171956: Allow PDF rendering to be triggered only by electron for single-article PDFs

ovasileva lowered the priority of this task from High to Medium.Sep 13 2017, 4:42 PM
ovasileva closed this task as Invalid.Sep 14 2017, 11:48 AM

Replaced by solution in T171956: Allow PDF rendering to be triggered only by electron for single-article PDFs

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL