Page MenuHomePhabricator

LoginNotify doesn't bundle notifications correctly
Closed, ResolvedPublic5 Estimated Story Points

Description

Steps to reproduce:

  1. Go incognito on your browser.
  2. Try logging (with wrong password) into your account 6 times (5 is the threshold limit for a notification to be generated from a known IP).
  3. Log in.
  4. The icon shows the correct number of failed attempts.
  5. The notification however always says "a failed attempt". Dumping the var ($this->event->getExtraParam( 'count', 0 )) being passed into the message always gives 1.

This was working fine until about ~1 month ago. What changed?

Event Timeline

kaldari edited projects, added Community-Tech-Sprint; removed Community-Tech.
kaldari set the point value for this task to 5.

Change 364609 had a related patch set uploaded (by Niharika29; owner: Niharika29):
[mediawiki/extensions/LoginNotify@master] Fix bundling issues with LoginNotify

https://gerrit.wikimedia.org/r/364609

Change 364609 merged by jenkins-bot:
[mediawiki/extensions/LoginNotify@master] Fix bundling issues with LoginNotify

https://gerrit.wikimedia.org/r/364609