Page MenuHomePhabricator

Enhanced RC expand/collapse arrows are not shown when starting from a conflict state
Closed, ResolvedPublic

Description

  1. Go to https://www.mediawiki.org/wiki/Special:RecentChanges?hidebots=1&hidecategorization=1&hideWikibase=1&urlversion=2&hideliu=1&userExpLevel=newcomer&enhanced=1 . Note that this is a conflict state (unregistered + newcomers) and that enhanced RC is enabled.
  2. Remove the "newcomer" filter. You should now see results. Note that the lines with multiple results don't have arrows to expand them, and the text styling is wrong generally.
  3. Refresh the page. Note that the arrows now appear, and the text styling is now correct.

Unstyled version:

Styled version:

Event Timeline

Catrope created this task.Jul 5 2017, 11:36 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 5 2017, 11:36 PM
Catrope claimed this task.Jul 5 2017, 11:37 PM
Catrope updated the task description. (Show Details)

Change 363509 had a related patch set uploaded (by Catrope; owner: Catrope):
[mediawiki/core@master] ChangesListSpecialPage: Don't short-circuit the ChangesList, instead format zero rows

https://gerrit.wikimedia.org/r/363509

This was an interesting bug and I found it pretty much by accident. The state you start with can't just be any zero-results state, it has to be a short-circuited state like a conflict. (Or, in the case of RecentchangesLinked, a nonexistent target page, that's how I found it.)

Checked the fix in betalabs.

Checked the fix in betalabs.

Really? The patch isn't merged yet...

Change 363509 merged by jenkins-bot:
[mediawiki/core@master] ChangesListSpecialPage: Don't short-circuit the ChangesList, instead format zero rows

https://gerrit.wikimedia.org/r/363509

Etonkovidova added a comment.EditedJul 17 2017, 7:53 PM

Hmm... there might have been some other factors affecting the manifestation of the issue, cause I definitely saw the bug happening and then not happening when I

Checked the fix in betalabs.

Really? The patch isn't merged yet...

Thx @Catrope for pointing out the missing factor!
Now, I checked the fix in betalabs after the last patch has been merged - all seems to be in place.

Etonkovidova closed this task as Resolved.Jul 17 2017, 7:53 PM