Maniphest T169873

mapPin icon is not vertically centered
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Volker_E
	Jul 6 2017, 12:37 PM

Tags

Referenced Files

	F8631925: image.png
	Jul 6 2017, 12:37 PM

Subscribers

Jdforrester-WMF

Description

As of v0.22.2 mapPin icon isn't vertically centered, resulting in

image.png (128×308 px, 2 KB)

at https://commons.wikimedia.org/wiki/Special:UploadWizard

Details

	Subject	Repo	Branch	Lines +/-
	icons: Vertically center mapPin icon	oojs/ui	master	+1 -1

Customize query in gerrit

Event Timeline

Volker_E created this task.Jul 6 2017, 12:37 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 6 2017, 12:37 PM

@RHo Here we also run into the issue how to position icons in the canvas when a modifier (mapPinAdd) is taken into account.

Change 363585 had a related patch set uploaded (by VolkerE; owner: VolkerE):
[oojs/ui@master] icons: Vertically center mapPin icon

https://gerrit.wikimedia.org/r/363585

gerritbot added a project: Patch-For-Review.Jul 6 2017, 12:53 PM

Volker_E moved this task from Backlog to Reviewing on the OOUI board.Jul 6 2017, 12:54 PM

Change 363585 merged by jenkins-bot:
[oojs/ui@master] icons: Vertically center mapPin icon

https://gerrit.wikimedia.org/r/363585

Jdforrester-WMF closed this task as Resolved.Jul 6 2017, 3:26 PM

Jdforrester-WMF moved this task from Reviewing to OOjs-UI-0.22.3 on the OOUI board.

Jdforrester-WMF edited projects, added OOUI (OOjs-UI-0.22.3); removed OOUI.

Jdforrester-WMF removed a project: Patch-For-Review.