[BUG] Empty state of search screen is not available in dark mode
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	RHo
	Jul 6 2017, 2:13 PM

Description

STEPS TO REPRODUCE

Open app and switch to dark mode
Go to search for an article
Tap on the delete icon to delete all search history

EXPECTED:

The Search empty state should appear, with background and text should use the standard dark theme colors, per other empty state screens:

Screenshot_20170706-160816.png (1×1 px, 75 KB)

ACTUAL:

Background is same color as light mode
text is white per light mode

Screenshot_20170706-160258.png (1×1 px, 111 KB)

OCCURRING ON

Pixel - Android 7.1.2, Wikipedia version 26.8.198-alpha-2017-06-16

Details

	Subject	Repo	Branch	Lines +/-
	Use dark background color in dark theme for "no recent searches"	apps/android/wikipedia	master	+1 -1

Customize query in gerrit

Related Objects

Mentioned Here: T150473: Update the Search bar background color to Base90 in Light mode

Event Timeline

RHo created this task.Jul 6 2017, 2:13 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 6 2017, 2:13 PM

RHo updated the task description. (Show Details)Jul 6 2017, 2:15 PM

Dbrant merged a task: T170016: Empty search results screen has low contrast in dark mode.Jul 10 2017, 2:25 PM

Dbrant added subscribers: • Niedzielski, Mdann52, • Deskana and 2 others.

Florian claimed this task.Jul 11 2017, 2:30 PM

What I'm asking myself, too is: Should the search bar atthe top be black (as it is currently) or also blue, like for the reading lists and/or history searchbars?

Change 364447 had a related patch set uploaded (by Florianschmidtwelzow; owner: Florianschmidtwelzow):
[apps/android/wikipedia@master] Use dark background color in dark theme for "no recent searches"

https://gerrit.wikimedia.org/r/364447

gerritbot added a project: Patch-For-Review.Jul 11 2017, 2:38 PM

Change 364447 merged by jenkins-bot:
[apps/android/wikipedia@master] Use dark background color in dark theme for "no recent searches"