Page MenuHomePhabricator

Inconsistent tool name format in new XTools
Closed, ResolvedPublic1 Estimated Story Points

Description

We have 3 different conventions for tool names in the new XTools:

  • Sentence case: Page history, Simple counter, etc.
  • Title case: Edit Counter
  • Camelcase: AdminStats, AdminScore

Let's pick one and stick to it.

Event Timeline

kaldari triaged this task as Medium priority.Jul 6 2017, 5:49 PM
kaldari set the point value for this task to 1.

All of the above is simply a throwback from the old XTools. I would go for Title Case.

I also prefer Title Case. As part of this task we might want to also make the internal routing names consistent too, e.g. autoedits vs topEdits vs ArticleInfo. For that I like CamelCase

Samwilson moved this task from Ready to In Development on the Community-Tech-Sprint board.
Samwilson subscribed.

I've updated the tool names: https://github.com/x-tools/xtools-rebirth/commit/3ffb843d765ef34342cf1ca713bfefb5c5aabbf1

I think all tool routes have been defined with both the all-lowercase tool name, and the camelcase equivalents, e.g.

@Route("/articleinfo", name="articleinfo")
@Route("/articleinfo", name="articleInfo")

Is there a reason to only have one or the other? It doesn't get exposed externally.

Having both routes seems sensible.

Is there a reason to only have one or the other? It doesn't get exposed externally.

Nope, just want to make sure developers don't get confused. So long as the lowercase version works everywhere I think we're all set.