Page MenuHomePhabricator

[Regression pre-wmf.8] "Uncaught TypeError: Cannot read property 'getTokens' of null" appears after adding a Code block for the second time or re-editing it
Open, LowPublic0 Estimated Story Points

Description

Steps to reproduce:

  1. Insert>Code block.
  2. Select a language.
  3. Add some code block and click on "Done"
  4. Re-open it and edit it.
  5. Click on "Done again".

There is an error in the console:

Uncaught TypeError: Cannot read property 'getTokens' of null

Event Timeline

Can't reproduce. If still broken for you can you leave more detailed steps (wiki, browser, page etc.)?

This is a recent regression on Beta cluster.
It's happening for all pages and I reproduced it in both Chrome and Firefox.

However, I am noticing now that it does not happen the first time when you add a code block. But try re-editing it or just open the code editor the second time and close it, that should give that error.

I can see it happening, but it's definitely deep inside the ace editor component, and nothing surrounding this seems to have actually changed in the last few months.

Deskana moved this task from To Triage to TR1: Releases on the VisualEditor board.
Deskana subscribed.

Needs fixing at some point, but does not appear to be actively breaking anything right now.

Deskana set the point value for this task to 1.Aug 25 2017, 10:31 AM
Deskana claimed this task.
Deskana changed the point value for this task from 1 to 0.

No longer reproducible, so must've been fixed at some point.

No longer reproducible, so must've been fixed at some point.

Still happening :) When you add a code block for the second time (and in all subsequent attempts) or re-edit it, sorry for not updating the summary and the steps to reproduce.

Screen Shot 2017-10-30 at 1.27.23 PM.png (728×1 px, 239 KB)

Ryasmeen renamed this task from [Regression pre-wmf.8] "Uncaught TypeError: Cannot read property 'getTokens' of null" appears after adding a Code block to [Regression pre-wmf.8] "Uncaught TypeError: Cannot read property 'getTokens' of null" appears after adding a Code block for the second time or re-editing it.Oct 30 2017, 8:34 PM
Ryasmeen updated the task description. (Show Details)