Page MenuHomePhabricator
Create Task
Maniphest T169929

iOS app requests summaries with non-normalized titles
Closed, ResolvedPublic
Actions

Description

The iOS app is requesting the summaries from RESTBase with spaces instead of underscores, so it not only hits a lot of 301 redirects observing worse latency, it also doesn't share the cached summaries with other users.

See https://logstash.wikimedia.org/goto/825f98ebb50ece5ab2a7309e20fefa37

To normalize the titles we have a JS library mediawiki-title

Event Timeline

• Pchelolo created this task.Jul 6 2017, 9:25 PM
Restricted Application added a project: Wikipedia-iOS-App-Backlog. · View Herald TranscriptJul 6 2017, 9:25 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
• JMinor triaged this task as Medium priority.Jul 6 2017, 10:32 PM
• JMinor moved this task from Needs Triage to Engineering Backlog on the Wikipedia-iOS-App-Backlog board.
• JMinor added a project: iOS-app-v5.6.0-Goat-On-A-Train.
• JMinor moved this task from Tasks from Product Backlog to Needs Engineering Sync on the iOS-app-v5.6.0-Goat-On-A-Train board.Jul 6 2017, 10:42 PM
• JMinor added subscribers: JoeWalsh, • JMinor.Jul 7 2017, 6:07 PM

@JoeWalsh this is the performance ticket I mentioned at standup. Currently parked in eng sync on Goat release.

• NHarateh_WMF moved this task from Needs Engineering Sync to Needs Code Review on the iOS-app-v5.6.0-Goat-On-A-Train board.Jul 13 2017, 6:52 PM
JoeWalsh claimed this task.Jul 13 2017, 6:56 PM
JoeWalsh added a comment.EditedJul 14 2017, 6:47 PM

@Pchelolo somewhat related question:

For titles with a /, I'm getting a response with a title of Not found.

https://en.wikipedia.org/api/rest_v1/page/summary/McDonnell_Douglas_F/A-18_Hornet

However, the same title works on enwiki:

https://en.wikipedia.org/wiki/McDonnell_Douglas_F/A-18_Hornet

• Pchelolo added a comment.Jul 14 2017, 6:53 PM

@JoeWalsh RESTBase uses / for routing, so all the titles in the request should be URI-encoded like encodeURIComponent(title). So the / becomes %2F

Mhurd moved this task from Needs Code Review to Needs Testing Criteria on the iOS-app-v5.6.0-Goat-On-A-Train board.Jul 15 2017, 2:33 AM
• JMinor moved this task from Needs Testing Criteria to Ready for PM Signoff on the iOS-app-v5.6.0-Goat-On-A-Train board.Aug 2 2017, 9:46 PM
• JMinor added a comment.Aug 2 2017, 11:33 PM

@Pchelolo this should be released to users next week

• JMinor closed this task as Resolved.Aug 14 2017, 7:41 PM

This is out. Please reopen if still an issue.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL