Page MenuHomePhabricator
Create Task
Maniphest T169975

Missing images render as broken img tags, not redlinks
Closed, ResolvedPublic
Actions

Description

PHP:

image.png (62×208 px, 3 KB)

Parsoid:
image.png (343×326 px, 5 KB)

With PHP it is clear we have created a "red link" and not just that the image failed to load due to some intermittent network failure.

The counterpoint is that as a document model, the Parsoid version is much more consistent. If we removed the <img> tag we'd need to put alt, link and dimensions somewhere else, and clients would need to be updated (although VE already special-cases mw:Error images to make our CE rendering look more like the PHP output)

Details

SubjectRepoBranchLines +/-
Add media info in a post-processing passmediawiki/services/parsoidmaster+1 K -1 K
Customize query in gerrit

Related Objects
Search...

StatusSubtypeAssignedTask
 OpenReleaseNoneT84936 Release VisualEditor-MediaWiki as "1.0"
 OpenNoneT50429 [Epic] Support editing parts of a page in VisualEditor-MediaWiki
 OpenNoneT54365 Explore performance gains from progressive (JIT?) de-alienation in VisualEditor
 OpenNoneT174303 Copy-pasting linked ISBN numbers from view mode HTML into VisualEditor inserts wikitext links to Special:BookSources (it should turn them into magic links?)
 OpenFeatureNoneT54091 The read HTML should have hinting to allow full DOM copying (as opposed to just rich copying) from read mode into VE surfaces
 OpenNoneT55784 [EPIC] Use Parsoid HTML for all page views
 DeclinedNoneT67243 Flow: Obey the Exlinks gadget (open external links in new tab/window)
 ResolvedCatropeT96855 A15. Flow rendering doesn't render external links correctly
 ResolvedSbaileyT58756 Parsoid doesn't give external links class="external free|text"
 Resolved• GWickeT55783 Use CSS-based citation numbering
 ResolvedNoneT62017 Flow: Reference numbers in Parsoid output aren't superscripted
 ResolvedssastryT64511 Mass rendering tests / visual diff
 ResolvedArlolraT53245 Link MediaWiki styles and create Parsoid-specific CSS styling to match MediaWiki's for differing DOM elements
 ResolvedDbrantT115488 Integrate the app fully with the Content Service.
 Resolved• bearNDT108777 Use Parsoid for new mobile-html-section routes
 Resolved• MhollowayT161008 Link preview offline error message is shown for missing pages that return a 404 HTTP status
 ResolvedNoneT119266 Red links displayed as regular links when Restbase enabled.
 DuplicateNoneT35084 VisualEditor: Interproject links are coloured correctly (lighter blue), but also have an external link icon
 ResolvedJdforrester-WMFT40726 VisualEditor: Links should follow the local CSS rules as if they were rendered in the view mode (e.g. external links shown with the external icon)
 Resolved• bearNDT117505 Copy device independent transformations from Android app to service
 OpenNoneT168555 Investigate what to do with WikiLinkFixer now that Parsoid supports red links
 ResolvedArlolraT39902 RFC: Implement rendering of redlinks in Parsoid HTML as post-processor
 ResolvedArlolraT169975 Missing images render as broken img tags, not redlinks

Event Timeline

Esanders created this task.Jul 7 2017, 11:10 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 7 2017, 11:10 AM
Esanders mentioned this in T169342: Gallery output for missing images is not consistent with PHP parser and is missing data.Jul 7 2017, 11:10 AM
wassan.anmol117 added a parent task: T39902: RFC: Implement rendering of redlinks in Parsoid HTML as post-processor.Jul 7 2017, 1:53 PM
cscott subscribed.Jul 11 2017, 3:40 PM

Discussed today at parsing-team meeting.

Some examples of PHP output for broken images with explicit link attributes at https://en.wikipedia.org/wiki/User:Cscott/Sandbox

Note that the link= attribute for the broken image gets ignored & replaced with a link to Special:Upload for a broken image:

There's some social aspects of the PHP design here, in particular the ability for readers to click through a redlink to fix it (in the same way that article redlinks work).

Two options were discussed.

Option "Stuff a span":

  1. replace <img> with <span>File:....</span>, preserving the overall tree structure of image markup for consistency.

2a) hoist any wikitext link attribute into data-mw for roundtripping
2b) alternatively, hoist the wikitext link property into a new origHref attribute (bikeshedding name welcome)

  1. replace href attribute of <a> tag with a direct link to [[special:upload]] for PHP compat (and social compatibility)
  2. leave the mw:Error in the typeof

Option "Use a non-broken image"

  1. Add filename as an alt attribute to the image, add a class to the a-tag, and change the img src to point to a real non-broken image (maybe [[Special:BrokenImage.png]] or something like that)

2a/2b, 3, 4) as above

Arlolra claimed this task.Jul 19 2017, 9:10 PM
Arlolra triaged this task as Medium priority.
ssastry moved this task from Needs Triage to Read Views on the Parsoid board.Jan 11 2018, 9:18 PM
Arlolra added a comment.May 2 2018, 11:40 PM

Ancient%20Order%20of%20Froth%20Blowers.diff.png (1×1 px, 864 KB)

This is an issue for the implementation of T118517 in https://gerrit.wikimedia.org/r/#/c/196532/ since the dimensions are only on the image which, as the task describes, is absent in the current php rendering.

Reedy edited projects, added Parsoid-Read-Views-Deprecated-Project; removed Parsoid.Sep 17 2018, 7:25 PM
ssastry moved this task from Uncategorized to Edge cases? on the Parsoid-Read-Views-Deprecated-Project board.Sep 20 2018, 3:39 PM
gerritbot subscribed.Dec 22 2018, 1:42 AM

Change 463125 had a related patch set uploaded (by Arlolra; owner: Arlolra):
[mediawiki/services/parsoid@master] [WIP] Add media info in a post-processing pass

https://gerrit.wikimedia.org/r/463125

gerritbot added a project: Patch-For-Review.Dec 22 2018, 1:42 AM
gerritbot added a comment.Feb 1 2019, 10:45 PM

Change 463125 merged by jenkins-bot:
[mediawiki/services/parsoid@master] Add media info in a post-processing pass

https://gerrit.wikimedia.org/r/463125

Arlolra closed this task as Resolved.Feb 6 2019, 6:28 PM
Stashbot mentioned this in T153080: Parse images synchronously without making imageinfo requests and use a final postprocessing pass to fixup image HTML.Feb 20 2019, 9:46 PM
Stashbot subscribed.

Mentioned in SAL (#wikimedia-operations) [2019-02-20T21:46:16Z] <arlolra> Updated Parsoid to 9b204a0 (T153080, T169975, T215824)

Stashbot mentioned this in T215824: AddMediaInfo pass isn't robust to link-in-link.Feb 20 2019, 9:46 PM
Aklapper edited projects, added Parsoid; removed Parsoid-Read-Views-Deprecated-Project.Feb 29 2020, 5:14 PM
Maintenance_bot removed a project: Patch-For-Review.Feb 29 2020, 6:11 PM
Arlolra added a comment.May 1 2020, 2:33 PM

https://www.mediawiki.org/wiki/Specs/HTML/2.1.0#Missing_media

Arlolra mentioned this in T266149: Run another round of visual diff testing after tweaking core patches that change media output to <figure>, etc..Jan 15 2021, 9:39 PM
Arlolra mentioned this in T273013: Dynamically adjust size for broken media.Jan 26 2021, 10:30 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL