Page MenuHomePhabricator

New versions of files appear to retain same aspect ratio as parent
Closed, ResolvedPublic

Description

Uploading a new image over an existing image retains the same aspect ratio as the parent image, even if this is changed. This means the new image is "squashed".

In the screenshot below, I uploaded an image (let's call it Image 1), then uploaded a cropped version over the top of that image (Image 2). It appears squashed. Trying to upload this image again (Image 3) results in Image 2 magically appearing normal again, but reverting to Image 2 just means that Image 3 is magically unsquished.

This problem persists over a purge and over a hard refresh of the browser window.

Screenshot 2017-07-07 18.01.50.png (1×1 px, 358 KB)

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Are you sure this was not the opposite – old thumbnail shown scaled to the new upload's aspect ratio? That would be caused by T38380: After re-uploading a file, users still see the browser-cached thumbnail for the old version.

This could be caused if parser or varnish cache arent purged, or if jobqueue super slow. Or a racecondition in the purge vs media code.

Are you sure this was not the opposite – old thumbnail shown scaled to the new upload's aspect ratio? That would be caused by T38380: After re-uploading a file, users still see the browser-cached thumbnail for the old version.

Might be. It was also displaying the "squashed" version in ns0.

It seems to have fixed itself, so it's likely the jobqueue. The file in question was https://wikimania2017.wikimedia.org/wiki/File:TM-logo-Montreal-imprime.png. (Local to wikimania2017wiki)

MarkTraceur claimed this task.
MarkTraceur subscribed.

Since this doesn't seem to be an issue, I'm closing it - if there is further necessary work, please file a new bug.