Page MenuHomePhabricator

Nothing shown in visual diff when editing invisible templates
Closed, ResolvedPublic1 Estimated Story Points


On FF56/Mac OS 10.12.15 when you edit the first template of a page, it shows a comment annotating an empty space and shows no content apart from the infobox.

Screen Shot 2017-07-10 at 2.09.03 PM.png (545×918 px, 80 KB)

Steps to reproduces

  1. Go to edit the Grace Sherwood article
  2. Edit the Pp-protected template, changing the expiry year from 2017 to 2018
  3. Review your changes, your wikitext diff should look like:

Screen Shot 2017-07-10 at 2.10.55 PM.png (340×911 px, 52 KB)


  1. No way of telling what is happening without looking at the sidebar.
  2. Doesn't tell which template changed.
  3. Doesn't tell which parameters changed.

(from )

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Esanders renamed this task from No context shown when editing the first template to Nothing shown in visual diff when editing invisible templates.Jul 10 2017, 11:01 AM

The problem is the template is invisible in the main document - in this case it only outputs to <indicators>

Deskana moved this task from To Triage to TR6: Visual diffs on the VisualEditor board.

Borrowing the yellow from T169325, and the icons from T170134 we could:

template update-nomore.png (156×755 px, 19 KB)

template update.png (156×755 px, 22 KB)

Deskana set the point value for this task to 1.Aug 23 2017, 3:46 PM

Change 432399 had a related patch set uploaded (by Esanders; owner: Esanders):
[mediawiki/extensions/VisualEditor@master] Use CE rendering for invisible templates

Describing the param changes was fixed in T188389 - although we could yet consider the red/green highlights...

Change 432399 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Use CE rendering for invisible templates

matmarex assigned this task to Esanders.
matmarex edited projects, added VisualEditor (Current work); removed VisualEditor.