Nothing shown in visual diff when editing invisible templates
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

On FF56/Mac OS 10.12.15 when you edit the first template of a page, it shows a comment annotating an empty space and shows no content apart from the infobox.

Screen Shot 2017-07-10 at 2.09.03 PM.png (545×918 px, 80 KB)

Steps to reproduces

Go to edit the Grace Sherwood article
Edit the Pp-protected template, changing the expiry year from 2017 to 2018
Review your changes, your wikitext diff should look like:

Screen Shot 2017-07-10 at 2.10.55 PM.png (340×911 px, 52 KB)

Problems

No way of telling what is happening without looking at the sidebar.
Doesn't tell which template changed.
Doesn't tell which parameters changed.

(from https://www.mediawiki.org/wiki/User:Prtksxna/VeDiff#Edit_first_template )

Details

	Project	Branch	Lines +/-	Subject
	mediawiki/extensions/VisualEditor	master	+14 -0	Use CE rendering for invisible templates

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Resolved	Esanders	T170107 Nothing shown in visual diff when editing invisible templates
Resolved	Esanders	T194410 VisualDiff: Re-consider using converter's "clipboard mode" to speed up rendering
Resolved	Esanders	T94130 Tech debt: Devise a stable way to create previews for ce nodes

Event Timeline

Prtksxna created this task.Jul 10 2017, 8:39 AM

Restricted Application added a project: VisualEditor. · View Herald TranscriptJul 10 2017, 8:39 AM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Prtksxna updated the task description. (Show Details)Jul 10 2017, 8:41 AM

Prtksxna added subscribers: Esanders, Tchanders.

Prtksxna updated the task description. (Show Details)Jul 10 2017, 8:44 AM

The problem is the template is invisible in the main document - in this case it only outputs to <indicators>

Deskana triaged this task as Low priority.Jul 18 2017, 7:17 PM

Deskana moved this task from To Triage to TR6: Visual diffs on the VisualEditor board.

Prtksxna updated the task description. (Show Details)Jul 20 2017, 11:04 AM

Borrowing the yellow from T169325, and the icons from T170134 we could:

template update-nomore.png (156×755 px, 19 KB)

Deskana set the point value for this task to 1.Aug 23 2017, 3:46 PM

Esanders added a subtask: T194410: VisualDiff: Re-consider using converter's "clipboard mode" to speed up rendering.May 10 2018, 3:53 PM

Esanders mentioned this in T194410: VisualDiff: Re-consider using converter's "clipboard mode" to speed up rendering.

Change 432399 had a related patch set uploaded (by Esanders; owner: Esanders):
[mediawiki/extensions/VisualEditor@master] Use CE rendering for invisible templates

https://gerrit.wikimedia.org/r/432399

gerritbot added a project: Patch-For-Review.May 10 2018, 4:22 PM

Describing the param changes was fixed in T188389 - although we could yet consider the red/green highlights...

After:

@Esanders

Deskana closed subtask T194410: VisualDiff: Re-consider using converter's "clipboard mode" to speed up rendering as Resolved.May 14 2018, 1:43 PM

Change 432399 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Use CE rendering for invisible templates

https://gerrit.wikimedia.org/r/432399

ReleaseTaggerBot added a project: MW-1.32-notes (WMF-deploy-2018-05-22 (1.32.0-wmf.5)).May 18 2018, 7:01 PM

matmarex closed this task as Resolved.Jun 14 2018, 6:55 PM

matmarex assigned this task to Esanders.

matmarex edited projects, added VisualEditor (Current work); removed VisualEditor.

Deskana moved this task from Incoming to Product owner review on the VisualEditor (Current work) board.Jun 18 2018, 1:06 PM

• Vvjjkkii reopened subtask T194410: VisualDiff: Re-consider using converter's "clipboard mode" to speed up rendering as Open.Jul 1 2018, 1:10 AM

CommunityTechBot closed subtask T194410: VisualDiff: Re-consider using converter's "clipboard mode" to speed up rendering as Resolved.Jul 2 2018, 3:15 PM

Nothing shown in visual diff when editing invisible templatesClosed, ResolvedPublic1 Estimated Story PointsActions