Page MenuHomePhabricator

'Restore all default settings' starts the invite tour and highlight count on RC page
Open, Needs TriagePublic

Description

  1. As a user with enabled RC filters go to Preferences and click on 'Restore all default settings (in all sections)'.
  2. Go to RC page - the invite tour will be displayed again. Also, the highlight count starts over, so a user would see the pulsing blue dot.

According to T144457: Invite users to opt in to the RC Filters beta from the RC page, and educate them about its features, the popover should be permanently dismissed after a user sees it.

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 10 2017, 9:46 PM

Can be solved with UserResetAllOptions hook, and copying old preference.

This is a little magic and potentially unintuitive to the user. Do we actually want to preserve this setting? Also, should there be a more general solution to this for certain kinds of preferences?

I agree there should definitely be a more general solution for unresettable preferences.

jmatazzoni added a subscriber: jmatazzoni.

So, reading this more carefully (and having tried it out), I now see that you only get the invitation again if you delete all your preferences—i.e., you don't get it if you just uncheck the New Filters beta. Given that, it doesn't seem so bad. We could maybe fix it one day, but I'm moving this off the Q1 board to Triage>Medium term.

Restricted Application added a project: Growth-Team. · View Herald TranscriptSep 2 2018, 3:40 PM