Linter count not updated on deleted page
Closed, DuplicatePublic
Actions

Assigned To

Authored By

	Lokal_Profil
	Jul 11 2017, 7:46 PM

Description

I discovered a linting error on one of my user subpage which I then decided to delete rather than correct. (the deleted page)

Afterwards that error is still counted on Special:LintErrors even if it does not appear on the sub page for that error.

Details

	Project	Branch	Lines +/-	Subject
	mediawiki/extensions/Linter	master	+60 -65	Fix lint error updating
	mediawiki/extensions/Linter	master	+9 -5	Use normal lint error updating logic for page deletions

Customize query in gerrit

Related Objects

Mentioned In: T298782: Linter seems to be not cleaning up after page deletion
rELINTa1421792e942: Use normal lint error updating logic for page deletions

Event Timeline

Lokal_Profil created this task.Jul 11 2017, 7:46 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 11 2017, 7:46 PM

Lokal_Profil renamed this task from Linger count not updated on deleted page to Linter count not updated on deleted page.Jul 11 2017, 7:46 PM

It is just a delay in updates since count updates are done a bit lazily.

I've seen delays in other numbers but this one stayed when they updated. Added a link to the deleted page above to give a timepoint.

Lokal_Profil updated the task description. (Show Details)Jul 12 2017, 8:17 AM

After re-reading the code it turns out we're not properly invalidating the totals cache when articles are deleted outright.

Change 382641 had a related patch set uploaded (by Legoktm; owner: Legoktm):
[mediawiki/extensions/Linter@master] Use normal lint error updating logic for page deletions

https://gerrit.wikimedia.org/r/382641

gerritbot added a project: Patch-For-Review.Oct 6 2017, 4:05 AM

Legoktm mentioned this in rELINTa1421792e942: Use normal lint error updating logic for page deletions.Oct 6 2017, 4:06 AM

Sebastian_Berlin-WMSE added a project: WMSE-Bug-Reporting-and-Translation-2017.Dec 5 2017, 10:51 AM

Sebastian_Berlin-WMSE moved this task from Backlog to Reported bugs on the WMSE-Bug-Reporting-and-Translation-2017 board.

Change 382641 merged by jenkins-bot:
[mediawiki/extensions/Linter@master] Use normal lint error updating logic for page deletions

https://gerrit.wikimedia.org/r/382641

ReleaseTaggerBot added a project: MW-1.31-release-notes (WMF-deploy-2018-02-20 (1.31.0-wmf.22)).Feb 19 2018, 1:00 PM

Amire80 awarded a token.Nov 12 2018, 9:34 AM

I think I still see this happening. http://he.wikipedia.org/wiki/special:LintErrors shows "54 errors" for "Multi colon escape" ("חילוף נקודתיים מרובים"), but if you click it, you'll see zero. These pages are deleted. It has been a few days since I deleted them, and it's still 54.

Amire80 removed a project: Patch-For-Review.Nov 12 2018, 9:37 AM

In T170313#4738842, @Amire80 wrote:

I think I still see this happening. http://he.wikipedia.org/wiki/special:LintErrors shows "54 errors" for "Multi colon escape" ("חילוף נקודתיים מרובים"), but if you click it, you'll see zero. These pages are deleted. It has been a few days since I deleted them, and it's still 54.

It's the same in the Bulgarian Wikipedia as well. We've cleared almost all LintErrors (including low priority ones), but there's still errors indicated in the LintErrors page:
https://bg.wikipedia.org/wiki/%D0%A1%D0%BF%D0%B5%D1%86%D0%B8%D0%B0%D0%BB%D0%BD%D0%B8:LintErrors

IKhitron added a subscriber: IKhitron.Nov 14 2018, 1:35 PM

Reise_Reise added a subscriber: Reise_Reise.Jul 21 2019, 3:49 PM

Izno moved this task from Backlog to Linter-UI on the MediaWiki-extensions-Linter board.Feb 18 2020, 3:10 PM

Legoktm removed Legoktm as the assignee of this task.May 21 2020, 11:34 PM