Error exploded when I moved to wmf.9
FWIW, the constant does seem to be defined:
hphpd> var_dump(constant('NS_MODULE'));
var_dump(constant('NS_MODULE'));
int(828)Not sure what's happening, needs more investigation.
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | Release | thcipriani | T167893 MW-1.30.0-wmf.9 deployment blockers | ||
| Resolved | PRODUCTION ERROR | Reedy | T170317 Notice: Use of undefined constant NS_MODULE - assumed 'NS_MODULE' in /srv/mediawiki/wmf-config/CommonSettings.php on line 3099 |
+MediaWiki-extensions-TemplateSandbox since that's the line line that seems problematic in CommonSettings.php
Easy to fix
Problem is swap to Extension Registration, it gets defined later on
$wgTemplateSandboxEditNamespaces[] = NS_MODULE;
Needs to become
$wgTemplateSandboxEditNamespaces[] = 828; // NS_MODULE
Change 364516 had a related patch set uploaded (by Reedy; owner: Reedy):
[operations/mediawiki-config@master] Can't use NS_MODULE constant
Change 364522 had a related patch set uploaded (by Thcipriani; owner: Thcipriani):
[operations/mediawiki-config@master] Remove use of NS_MODULE in CommonSettings
Change 364516 merged by jenkins-bot:
[operations/mediawiki-config@master] Can't use NS_MODULE constant
Mentioned in SAL (#wikimedia-operations) [2017-07-11T20:23:24Z] <thcipriani@tin> Synchronized wmf-config/CommonSettings.php: [[gerrit:364516|Can't use NS_MODULE constant]] T170317 (duration: 00m 43s)
For the record, I pointed this out to @Legoktm on July 2. He tried to fix it with rETSA841397f1b7ca: Allow extensions to register additional namespaces in extension.json, rELUAab9ae6efe041: Set "TemplateSandboxEditNamespaces" in extension.json, and rOMWC211621b61395: Check that NS_MODULE is defined before using it rather than the simple fix done here, but the last of those apparently didn't get merged.