Page MenuHomePhabricator

Replace Flow DI (pimple) with MediaWikiServices
Open, Needs TriagePublic

Description

Instead of using its own DI system, Flow should migrate to MediaWikiServices.

Details

SubjectRepoBranchLines +/-
mediawiki/extensions/Flowmaster+53 -48
mediawiki/extensions/Flowmaster+126 -114
mediawiki/extensions/Flowmaster+70 -53
mediawiki/extensions/Flowmaster+17 -10
mediawiki/extensions/Flowmaster+4 -6
mediawiki/extensions/Flowmaster+7 -1
mediawiki/extensions/Flowmaster+118 -50
mediawiki/extensions/Flowmaster+69 -41
mediawiki/extensions/Flowmaster+16 -9
mediawiki/extensions/Flowmaster+119 -42
mediawiki/extensions/Flowmaster+30 -22
mediawiki/extensions/Flowmaster+41 -15
mediawiki/extensions/Flowmaster+19 -7
mediawiki/extensions/Flowmaster+8 -6
mediawiki/extensions/Flowmaster+9 -11
mediawiki/extensions/Flowmaster+301 -151
mediawiki/extensions/Flowmaster+160 -41
mediawiki/extensions/Flowmaster+59 -77
mediawiki/extensions/Flowmaster+14 -21
mediawiki/extensions/Flowmaster+26 -37
mediawiki/extensions/Flowmaster+14 -21
mediawiki/extensions/Flowmaster+26 -36
mediawiki/extensions/Flowmaster+32 -43
mediawiki/extensions/Flowmaster+66 -94
mediawiki/extensions/Flowmaster+23 -39
mediawiki/extensions/Flowmaster+64 -62
mediawiki/extensions/Flowmaster+30 -57
mediawiki/extensions/Flowmaster+42 -20
mediawiki/extensions/Flowmaster+20 -6
mediawiki/extensions/Flowmaster+31 -15
mediawiki/extensions/Flowmaster+41 -4
Show related patches Customize query in gerrit

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes
Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Pimple is now closed for changes. No new features will be added and no cosmetic changes will be accepted either. The only accepted changes are compatiblity with newer PHP versions and security issue fixes.

https://github.com/silexphp/Pimple/commit/855b0196f58541b312d947205b628aab1296603b

Upstream (pimple) have announced they're no longer accepting patches (except for security patches and PHP version support bumps), so this would be nice to get done sooner or later. Any volunteers? :-)

DannyS712 subscribed.

Upstream (pimple) have announced they're no longer accepting patches (except for security patches and PHP version support bumps), so this would be nice to get done sooner or later. Any volunteers? :-)

I should have time to investigate this soon

Upstream (pimple) have announced they're no longer accepting patches (except for security patches and PHP version support bumps), so this would be nice to get done sooner or later. Any volunteers? :-)

I should have time to investigate this soon

That'd be brill. Thanks!

That'd be brill. Thanks!

sorry to disappoint - I started looking into it, and its a whole lot harder than I thought. I'm happy to review patches for this, but won't be fixing it myself

Change 675302 had a related patch set uploaded (by DannyS712; author: DannyS712):
[mediawiki/extensions/Flow@master] Start cleaning up use of container/pimple

https://gerrit.wikimedia.org/r/675302

Took another look, might be easier to do in multiple steps

Change 675303 had a related patch set uploaded (by DannyS712; author: DannyS712):
[mediawiki/extensions/Flow@master] Add ServiceWiring.php and move first service

https://gerrit.wikimedia.org/r/675303

Change 675303 merged by jenkins-bot:

[mediawiki/extensions/Flow@master] Add ServiceWiring.php and move first services

https://gerrit.wikimedia.org/r/675303

Change 676360 had a related patch set uploaded (by DannyS712; author: DannyS712):

[mediawiki/extensions/Flow@master] Move the next few services to ServiceWiring.php

https://gerrit.wikimedia.org/r/676360

Change 676360 merged by jenkins-bot:

[mediawiki/extensions/Flow@master] Move the next few services to ServiceWiring.php

https://gerrit.wikimedia.org/r/676360

Change 676525 had a related patch set uploaded (by DannyS712; author: DannyS712):

[mediawiki/extensions/Flow@master] Move FlowUser and FlowPermissions to ServiceWiring.php

https://gerrit.wikimedia.org/r/676525

Change 676525 merged by jenkins-bot:

[mediawiki/extensions/Flow@master] Move FlowUser and FlowPermissions to ServiceWiring.php

https://gerrit.wikimedia.org/r/676525

Change 677399 had a related patch set uploaded (by DannyS712; author: DannyS712):

[mediawiki/extensions/Flow@master] Move repository.tree and a few others to ServiceWiring.php

https://gerrit.wikimedia.org/r/677399

Change 677399 merged by jenkins-bot:

[mediawiki/extensions/Flow@master] Move repository.tree and a few others to ServiceWiring.php

https://gerrit.wikimedia.org/r/677399

Change 678415 had a related patch set uploaded (by DannyS712; author: DannyS712):

[mediawiki/extensions/Flow@master] Move templating and related to ServiceWiring.php

https://gerrit.wikimedia.org/r/678415

Change 678416 had a related patch set uploaded (by DannyS712; author: DannyS712):

[mediawiki/extensions/Flow@master] Move formatter.revision.factory and some formatters to ServiceWiring.php

https://gerrit.wikimedia.org/r/678416

Change 678421 had a related patch set uploaded (by DannyS712; author: DannyS712):

[mediawiki/extensions/Flow@master] container.php: merge single use indexes entries

https://gerrit.wikimedia.org/r/678421

Change 678648 had a related patch set uploaded (by DannyS712; author: DannyS712):

[mediawiki/extensions/Flow@master] container.php: merge single use listeners entries

https://gerrit.wikimedia.org/r/678648

Change 678421 merged by jenkins-bot:

[mediawiki/extensions/Flow@master] container.php: merge single use indexes entries

https://gerrit.wikimedia.org/r/678421

Change 678649 had a related patch set uploaded (by DannyS712; author: DannyS712):

[mediawiki/extensions/Flow@master] container.php: merge some single use indexes entries

https://gerrit.wikimedia.org/r/678649

Change 678701 had a related patch set uploaded (by DannyS712; author: DannyS712):

[mediawiki/extensions/Flow@master] container.php: merge more single use index entries

https://gerrit.wikimedia.org/r/678701

Change 678702 had a related patch set uploaded (by DannyS712; author: DannyS712):

[mediawiki/extensions/Flow@master] container.php: merge some single use backend entries

https://gerrit.wikimedia.org/r/678702

Change 678703 had a related patch set uploaded (by DannyS712; author: DannyS712):

[mediawiki/extensions/Flow@master] container.php: merge some single use mapper entries

https://gerrit.wikimedia.org/r/678703

Change 678648 merged by jenkins-bot:

[mediawiki/extensions/Flow@master] container.php: merge single use listeners entries

https://gerrit.wikimedia.org/r/678648

Change 678649 merged by jenkins-bot:

[mediawiki/extensions/Flow@master] container.php: merge some single use index entries

https://gerrit.wikimedia.org/r/678649

Change 678701 merged by jenkins-bot:

[mediawiki/extensions/Flow@master] container.php: merge more single use index entries

https://gerrit.wikimedia.org/r/678701

Change 701724 had a related patch set uploaded (by DannyS712; author: DannyS712):

[mediawiki/extensions/Flow@master] container.php: merge some single use backend entries

https://gerrit.wikimedia.org/r/701724

Change 678702 abandoned by DannyS712:

[mediawiki/extensions/Flow@master] container.php: merge some single use backend entries

Reason:

my git isn't letting me rebase this properly, so abandoning and redoing at https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Flow/ /701724

https://gerrit.wikimedia.org/r/678702

Change 702009 had a related patch set uploaded (by DannyS712; author: DannyS712):

[mediawiki/extensions/Flow@master] container.php: merge some single use mapper entries

https://gerrit.wikimedia.org/r/702009

Change 678703 abandoned by DannyS712:

[mediawiki/extensions/Flow@master] container.php: merge some single use mapper entries

Reason:

my git isn't letting me rebase this properly, so abandoning and redoing at https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Flow/ /702009

https://gerrit.wikimedia.org/r/678703

Change 701724 merged by jenkins-bot:

[mediawiki/extensions/Flow@master] container.php: merge some single use backend entries

https://gerrit.wikimedia.org/r/701724

Change 702009 merged by jenkins-bot:

[mediawiki/extensions/Flow@master] container.php: merge some single use mapper entries

https://gerrit.wikimedia.org/r/702009

Change 702725 had a related patch set uploaded (by DannyS712; author: DannyS712):

[mediawiki/extensions/Flow@master] container.php: merge more single-use entries

https://gerrit.wikimedia.org/r/702725

Change 702725 merged by jenkins-bot:

[mediawiki/extensions/Flow@master] container.php: merge more single-use entries

https://gerrit.wikimedia.org/r/702725

Change 703423 had a related patch set uploaded (by DannyS712; author: DannyS712):

[mediawiki/extensions/Flow@master] Add a new StorageManager service

https://gerrit.wikimedia.org/r/703423

Change 703424 had a related patch set uploaded (by DannyS712; author: DannyS712):

[mediawiki/extensions/Flow@master] container.php: merge storage.post_summary.listeners.username

https://gerrit.wikimedia.org/r/703424

Change 703424 abandoned by DannyS712:

[mediawiki/extensions/Flow@master] Add a ListenerFactory service

Reason:

https://gerrit.wikimedia.org/r/703424

Change 703423 abandoned by DannyS712:

[mediawiki/extensions/Flow@master] Add a new StorageManager service

Reason:

https://gerrit.wikimedia.org/r/703423

Change #1034608 had a related patch set uploaded (by DannyS712; author: DannyS712):

[mediawiki/extensions/Flow@master] container.php: merge `storage.manager_list` entry into `storage`

https://gerrit.wikimedia.org/r/1034608

Change #1034609 had a related patch set uploaded (by DannyS712; author: DannyS712):

[mediawiki/extensions/Flow@master] container.php: merge `storage.post_summary.listeners.username` into only user

https://gerrit.wikimedia.org/r/1034609

Change #1034611 had a related patch set uploaded (by DannyS712; author: DannyS712):

[mediawiki/extensions/Flow@master] container.php: move some services to ServiceWiring.php

https://gerrit.wikimedia.org/r/1034611

Change #1034619 had a related patch set uploaded (by DannyS712; author: DannyS712):

[mediawiki/extensions/Flow@master] container.php: move `url_generator` and `storage.workflow.mapper` to ServiceWiring.php

https://gerrit.wikimedia.org/r/1034619

Change #1034620 had a related patch set uploaded (by DannyS712; author: DannyS712):

[mediawiki/extensions/Flow@master] container.php: move `templating` to ServiceWiring.php

https://gerrit.wikimedia.org/r/1034620

Change #1034608 merged by jenkins-bot:

[mediawiki/extensions/Flow@master] container.php: merge `storage.manager_list` entry into `storage`

https://gerrit.wikimedia.org/r/1034608

Change #1034609 merged by jenkins-bot:

[mediawiki/extensions/Flow@master] container.php: merge `storage.post_summary.listeners.username` into only user

https://gerrit.wikimedia.org/r/1034609

Change #1034611 merged by jenkins-bot:

[mediawiki/extensions/Flow@master] container.php: move some services to ServiceWiring.php

https://gerrit.wikimedia.org/r/1034611

Change #1034619 merged by jenkins-bot:

[mediawiki/extensions/Flow@master] container.php: move `url_generator` and `storage.workflow.mapper` to ServiceWiring.php

https://gerrit.wikimedia.org/r/1034619

Change #1034986 had a related patch set uploaded (by DannyS712; author: DannyS712):

[mediawiki/extensions/Flow@master] container.php: move `formatter.revision.factory` to ServiceWiring.php

https://gerrit.wikimedia.org/r/1034986

Change #1034987 had a related patch set uploaded (by DannyS712; author: DannyS712):

[mediawiki/extensions/Flow@master] container.php: move 10 formatters to ServiceWiring.php

https://gerrit.wikimedia.org/r/1034987

Change #1034988 had a related patch set uploaded (by DannyS712; author: DannyS712):

[mediawiki/extensions/Flow@master] container.php: move `deferred_queue` to ServiceWiring.php

https://gerrit.wikimedia.org/r/1034988

Change #1034620 merged by jenkins-bot:

[mediawiki/extensions/Flow@master] container.php: move `templating` to ServiceWiring.php

https://gerrit.wikimedia.org/r/1034620

Change #1034986 merged by jenkins-bot:

[mediawiki/extensions/Flow@master] container.php: move `formatter.revision.factory` to ServiceWiring.php

https://gerrit.wikimedia.org/r/1034986

Change #1034987 merged by jenkins-bot:

[mediawiki/extensions/Flow@master] container.php: move 11 formatters to ServiceWiring.php

https://gerrit.wikimedia.org/r/1034987

Change #1034988 merged by jenkins-bot:

[mediawiki/extensions/Flow@master] container.php: move `deferred_queue` to ServiceWiring.php

https://gerrit.wikimedia.org/r/1034988

Change #678415 abandoned by DannyS712:

[mediawiki/extensions/Flow@master] Move templating and related to ServiceWiring.php

Reason:

since this has been done in various other patches

https://gerrit.wikimedia.org/r/678415

Change #678416 abandoned by DannyS712:

[mediawiki/extensions/Flow@master] Move formatter.revision.factory and some formatters to ServiceWiring.php

Reason:

since I sent this patch all have since been done in other patches

https://gerrit.wikimedia.org/r/678416

Change #1041256 had a related patch set uploaded (by DannyS712; author: DannyS712):

[mediawiki/extensions/Flow@master] container.php: inline controller.abusefilter into controller.spamfilter

https://gerrit.wikimedia.org/r/1041256

Change #1041258 had a related patch set uploaded (by DannyS712; author: DannyS712):

[mediawiki/extensions/Flow@master] container.php: move `controller.opt_in` to ServiceWiring.php

https://gerrit.wikimedia.org/r/1041258

Change #1041259 had a related patch set uploaded (by DannyS712; author: DannyS712):

[mediawiki/extensions/Flow@master] container.php: move `storage.(wiki|url)_reference` to ServiceWiring.php

https://gerrit.wikimedia.org/r/1041259

Change #1041262 had a related patch set uploaded (by DannyS712; author: DannyS712):

[mediawiki/extensions/Flow@master] container.php: move `storage.topic_list*` to ServiceWiring.php

https://gerrit.wikimedia.org/r/1041262

Change #1041266 had a related patch set uploaded (by DannyS712; author: DannyS712):

[mediawiki/extensions/Flow@master] container.php: move `storage.workflow` to ServiceWiring.php

https://gerrit.wikimedia.org/r/1041266

Change #1041256 merged by jenkins-bot:

[mediawiki/extensions/Flow@master] container.php: inline `controller.abusefilter` into `controller.spamfilter`

https://gerrit.wikimedia.org/r/1041256

Change #1041258 merged by jenkins-bot:

[mediawiki/extensions/Flow@master] container.php: move `controller.opt_in` to ServiceWiring.php

https://gerrit.wikimedia.org/r/1041258

Change #1041259 merged by jenkins-bot:

[mediawiki/extensions/Flow@master] container.php: move `storage.(wiki|url)_reference` to ServiceWiring.php

https://gerrit.wikimedia.org/r/1041259

Change #1041262 merged by jenkins-bot:

[mediawiki/extensions/Flow@master] container.php: move `storage.topic_list*` to ServiceWiring.php

https://gerrit.wikimedia.org/r/1041262