Page MenuHomePhabricator
Create Task
Maniphest T170371

Allow reviewing your changes as visual diff in NWE
Closed, ResolvedPublic8 Estimated Story Points
Actions

Description

Currently, when you edit in NWE and review your changes, the visual diff button is grayed out.
But since visual diffs now work for historical diffs I imagine it should be possible to add that functionality for NWE edits, too.

Details

SubjectRepoBranchLines +/-
Show visual diffs in wikitext modemediawiki/extensions/VisualEditormaster+51 -51
Customize query in gerrit

Related Objects

Event Timeline

Schnark created this task.Jul 12 2017, 7:07 AM
Restricted Application added a project: VisualEditor. · View Herald TranscriptJul 12 2017, 7:07 AM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Esanders subscribed.Jul 12 2017, 2:30 PM

We probably want to fix T170269 before making historical visual diffs more available.

• Deskana triaged this task as Low priority.Jul 13 2017, 3:38 PM
• Deskana moved this task from To Triage to TR6: Visual diffs on the VisualEditor board.
• Deskana added a project: Epic.
gerritbot subscribed.Jul 17 2017, 4:40 PM

Change 365645 had a related patch set uploaded (by Esanders; owner: Esanders):
[mediawiki/extensions/VisualEditor@master] Show visual diffs in wikitext mode

https://gerrit.wikimedia.org/r/365645

gerritbot added a project: Patch-For-Review.Jul 17 2017, 4:40 PM
• Deskana set the point value for this task to 1.Aug 22 2017, 2:29 PM
gerritbot added a comment.Oct 11 2017, 8:12 PM

Change 365645 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Show visual diffs in wikitext mode

https://gerrit.wikimedia.org/r/365645

• Deskana closed this task as Resolved.Oct 11 2017, 8:26 PM
• Deskana assigned this task to Esanders.
Restricted Application added a project: User-Ryasmeen. · View Herald TranscriptOct 11 2017, 8:26 PM
• Deskana changed the point value for this task from 1 to 8.Oct 11 2017, 9:00 PM
ReleaseTaggerBot added a project: MW-1.31-release-notes (WMF-deploy-2017-10-17 (1.31.0-wmf.4)).Oct 11 2017, 9:00 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL