Page MenuHomePhabricator
Create Task
Maniphest T170382

[NWE + CodeMirror] Syntaxhighlighting and actual text out of sync for some special characters
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

Steps to reproduce:

  1. Edit in NWE with syntaxhighlighting enabled.
  2. Copy a word with a soft hyphen in it, I used "Kindergarten­stu­die" from https://de.wikipedia.org/w/index.php?title=Sebastian_Kurz&diff=prev&oldid=167161199.
  3. Insert it.

Note that CodeMirror shows red dots for the SHYs, which increases the length of the displayed syntax, while these characters are invisible in the actual text. The same might apply for other such characters as well.

Details

SubjectRepoBranchLines +/-
[DNM] Explore zero-width character bugmediawiki/extensions/CodeMirrormaster+3 -1
VE CodeMirror: Don't handle any specialCharsmediawiki/extensions/CodeMirrormaster+1 -0
Customize query in gerrit

Event Timeline

Schnark created this task.Jul 12 2017, 9:50 AM
Restricted Application added a project: VisualEditor. · View Herald TranscriptJul 12 2017, 9:50 AM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
gerritbot subscribed.Jul 12 2017, 2:24 PM

Change 364736 had a related patch set uploaded (by Esanders; owner: Esanders):
[mediawiki/extensions/CodeMirror@master] VE CodeMirror: Don't handle any specialChars

https://gerrit.wikimedia.org/r/364736

gerritbot added a project: Patch-For-Review.Jul 12 2017, 2:24 PM
gerritbot added a comment.Jul 13 2017, 2:04 PM

Change 364736 merged by jenkins-bot:
[mediawiki/extensions/CodeMirror@master] VE CodeMirror: Don't handle any specialChars

https://gerrit.wikimedia.org/r/364736

ReleaseTaggerBot added a project: MW-1.30-release-notes (WMF-deploy-2017-07-18_(1.30.0-wmf.10)).Jul 13 2017, 3:00 PM
Dvorapa subscribed.Jul 14 2017, 10:14 PM
• Deskana added subscribers: Esanders, • Deskana.Jul 18 2017, 7:14 PM

@Esanders Does the above patch fix this issue?

Esanders added a comment.Jul 19 2017, 9:46 PM

I believe so

• Deskana closed this task as Resolved.Jul 19 2017, 11:12 PM
• Deskana assigned this task to Esanders.
• Deskana triaged this task as Medium priority.
• Deskana set the point value for this task to 1.
Restricted Application added a project: User-Ryasmeen. · View Herald TranscriptJul 19 2017, 11:12 PM
Liuxinyu970226 moved this task from Backlog to Done on the MediaWiki-extensions-CodeMirror board.Feb 9 2018, 4:01 PM
Restricted Application added a project: Community-Tech. · View Herald TranscriptFeb 9 2018, 4:01 PM
• TBolliger moved this task from New & TBD Tickets to Archive on the Community-Tech board.Feb 14 2018, 1:12 AM
Jdforrester-WMF moved this task from To Triage to Current work on the VisualEditor board.Feb 21 2018, 5:19 PM
Jdforrester-WMF edited projects, added VisualEditor (Current work); removed VisualEditor.
Jdforrester-WMF moved this task from Incoming to Product owner review on the VisualEditor (Current work) board.Feb 21 2018, 10:30 PM
gerritbot added a comment.Apr 7 2021, 9:43 AM

Change 677502 had a related patch set uploaded (by Awight; author: Awight):

[mediawiki/extensions/CodeMirror@master] [DNM] Explore zero-width character bug

https://gerrit.wikimedia.org/r/677502

Maintenance_bot edited projects, added VisualEditor; removed VisualEditor (Current work).Apr 7 2021, 9:45 AM
awight subscribed.Apr 7 2021, 9:47 AM

No action needs to be taken. We noticed that zero-width characters can be displayed by CodeMirror which is nice, but that the behavior is currently disabled to avoid misalignment. There is no user request or use case that would make us push for a fix here, just leaving as an observation.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL