Page MenuHomePhabricator
Create Task
Maniphest T170388

Polish CSS of the Forms (Morphology) Section
Closed, ResolvedPublic
Actions

Description

  • Forms section
    • Align with headline 'Forms'
    • Font size < headline
    • Form representation should not bold and also smaller font -size
    • Statements
      • Heading should be 'Statements about F1'
      • Smaller size and moved to right

Details

Related Changes in Gerrit:
SubjectAuthorRepoBranchLines +/-
Rename title Forms to MorphologyAleksey Bekh-Ivanov (WMDE)mediawiki/extensions/WikibaseLexememaster+2 -2
Change Form's statements header textAleksey Bekh-Ivanov (WMDE)mediawiki/extensions/WikibaseLexememaster+48 -17
Add method creating StatementGroupListViewAleksey Bekh-Ivanov (WMDE)mediawiki/extensions/Wikibasemaster+31 -8
Representation widget doesn't explode vertically when editedAleksey Bekh-Ivanov (WMDE)mediawiki/extensions/WikibaseLexememaster+23 -15
Remove unused styles for nonexistent form representation widgetAleksey Bekh-Ivanov (WMDE)mediawiki/extensions/WikibaseLexememaster+0 -19
Align form contents with headline 'Forms'Aleksey Bekh-Ivanov (WMDE)mediawiki/extensions/WikibaseLexememaster+22 -6
Customize query in gerrit

Related Objects
Search...

Event Timeline

• Aleksey_WMDE created this task.Jul 12 2017, 10:35 AM
• Aleksey_WMDE moved this task from Proposed to Doing on the Wikidata-Former-Sprint-Board board.
gerritbot subscribed.Jul 12 2017, 10:41 AM

Change 364690 had a related patch set uploaded (by Aleksey Bekh-Ivanov (WMDE); owner: Aleksey Bekh-Ivanov (WMDE)):
[mediawiki/extensions/WikibaseLexeme@master] Rename title Forms to Morphology

https://gerrit.wikimedia.org/r/364690

gerritbot added a project: Patch-For-Review.Jul 12 2017, 10:41 AM
• Aleksey_WMDE mentioned this in rEWLEb2feeb147746: Rename title Forms to Morphology.Jul 12 2017, 10:43 AM
gerritbot added a comment.Jul 12 2017, 11:13 AM

Change 364693 had a related patch set uploaded (by Aleksey Bekh-Ivanov (WMDE); owner: Aleksey Bekh-Ivanov (WMDE)):
[mediawiki/extensions/WikibaseLexeme@master] Align form contents with headline 'Morphology'

https://gerrit.wikimedia.org/r/364693

• Aleksey_WMDE mentioned this in rEWLE6501ed158e0e: Align form contents with headline 'Morphology'.Jul 12 2017, 11:15 AM
gerritbot added a comment.Jul 12 2017, 11:17 AM

Change 364694 had a related patch set uploaded (by Aleksey Bekh-Ivanov (WMDE); owner: Aleksey Bekh-Ivanov (WMDE)):
[mediawiki/extensions/WikibaseLexeme@master] Remove unused styles for nonexistent form representation widget

https://gerrit.wikimedia.org/r/364694

• Aleksey_WMDE mentioned this in rEWLE1e7acdfa5dc2: Remove unused styles for nonexistent form representation widget.Jul 12 2017, 11:17 AM
• Aleksey_WMDE updated the task description. (Show Details)Jul 12 2017, 1:25 PM
gerritbot added a comment.Jul 12 2017, 1:38 PM

Change 364723 had a related patch set uploaded (by Aleksey Bekh-Ivanov (WMDE); owner: Aleksey Bekh-Ivanov (WMDE)):
[mediawiki/extensions/WikibaseLexeme@master] Representation widget doesn't explode vertically

https://gerrit.wikimedia.org/r/364723

• Aleksey_WMDE mentioned this in rEWLEdb57947ca144: Representation widget doesn't explode vertically when edited.Jul 12 2017, 1:39 PM
• Aleksey_WMDE mentioned this in rEWLE4c04b935e282: Representation widget doesn't explode vertically.
Lydia_Pintscher subscribed.Jul 12 2017, 2:16 PM

Please do not rename the Forms section to Morphology. That is a change that has more far-reaching consequences than just this heading. That's not happening without a discussion with me please.

• James_Budday added a comment.Jul 12 2017, 2:24 PM

My first suggestion was "Inflected Forms."

The reasoning being that "Forms" was too vague and could lead to mix ups like whether Color vs Colour are 2 different forms or whether they are alternate lemma for the same lexeme (which is what I understand to be the correct interpretation).

No need to have the discussion now, just wanted to let you know what the reasoning was.

gerritbot added a comment.Jul 12 2017, 3:52 PM

Change 364767 had a related patch set uploaded (by Aleksey Bekh-Ivanov (WMDE); owner: Aleksey Bekh-Ivanov (WMDE)):
[mediawiki/extensions/Wikibase@master] Add method creating StatementGroupListView

https://gerrit.wikimedia.org/r/364767

gerritbot added a comment.Jul 12 2017, 3:54 PM

Change 364768 had a related patch set uploaded (by Aleksey Bekh-Ivanov (WMDE); owner: Aleksey Bekh-Ivanov (WMDE)):
[mediawiki/extensions/WikibaseLexeme@master] Change Form's statements header text

https://gerrit.wikimedia.org/r/364768

• Aleksey_WMDE updated the task description. (Show Details)Jul 12 2017, 3:55 PM
• Aleksey_WMDE mentioned this in rEWLEd309e29a71b0: Change Form's statements header text.Jul 12 2017, 3:55 PM
• Aleksey_WMDE updated the task description. (Show Details)Jul 12 2017, 3:57 PM
• Aleksey_WMDE moved this task from Doing to Review on the Wikidata-Former-Sprint-Board board.
• Aleksey_WMDE mentioned this in rEWLE6d04cd7caa7c: Rename title Forms to Morphology.Jul 12 2017, 3:59 PM
• Aleksey_WMDE mentioned this in rEWLEd30a7ba969f2: Align form contents with headline 'Morphology'.
• Aleksey_WMDE mentioned this in rEWLE7bee690e298d: Remove unused styles for nonexistent form representation widget.
• Aleksey_WMDE mentioned this in rEWLE3af4cfd9b252: Representation widget doesn't explode vertically when edited.
• Aleksey_WMDE mentioned this in rEWLEc12a22d4db56: Change Form's statements header text.
• Aleksey_WMDE mentioned this in rEWLEb0e61ecf9809: Change Form's statements header text.Jul 12 2017, 4:03 PM
• Aleksey_WMDE mentioned this in rEWLEf25dd32ff18a: Align form contents with headline 'Forms'.Jul 12 2017, 4:18 PM
• Aleksey_WMDE mentioned this in rEWLEc56918c83e34: Remove unused styles for nonexistent form representation widget.
• Aleksey_WMDE mentioned this in rEWLE19519dacc754: Representation widget doesn't explode vertically when edited.
• Aleksey_WMDE mentioned this in rEWLE9106faad0599: Align form contents with headline 'Morphology'.
• Aleksey_WMDE mentioned this in rEWLEfba1e1385bd0: Change Form's statements header text.
• Aleksey_WMDE updated the task description. (Show Details)Jul 12 2017, 4:27 PM
• Aleksey_WMDE mentioned this in rEWLEfbbaf2fd6df6: Change Form's statements header text.Jul 12 2017, 4:43 PM
gerritbot added a comment.Jul 12 2017, 6:43 PM

Change 364693 merged by jenkins-bot:
[mediawiki/extensions/WikibaseLexeme@master] Align form contents with headline 'Forms'

https://gerrit.wikimedia.org/r/364693

gerritbot added a comment.Jul 12 2017, 6:43 PM

Change 364694 merged by jenkins-bot:
[mediawiki/extensions/WikibaseLexeme@master] Remove unused styles for nonexistent form representation widget

https://gerrit.wikimedia.org/r/364694

gerritbot added a comment.Jul 12 2017, 6:45 PM

Change 364723 merged by jenkins-bot:
[mediawiki/extensions/WikibaseLexeme@master] Representation widget doesn't explode vertically when edited

https://gerrit.wikimedia.org/r/364723

gerritbot added a comment.Jul 13 2017, 7:58 AM

Change 364767 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Add method creating StatementGroupListView

https://gerrit.wikimedia.org/r/364767

• Aleksey_WMDE mentioned this in rEWLEda18d057225b: Change Form's statements header text.Jul 13 2017, 11:11 AM
• Aleksey_WMDE mentioned this in rEWLE7cf1a60a2b42: Change Form's statements header text.
• Aleksey_WMDE mentioned this in rEWLEc075783d3686: Change Form's statements header text.Jul 13 2017, 12:03 PM
WMDE-leszek removed • Aleksey_WMDE as the assignee of this task.Jul 13 2017, 12:43 PM
WMDE-leszek moved this task from Review to Backlog on the Wikidata-Former-Sprint-Board board.
WMDE-leszek subscribed.

All done except the section header. Moving back to Backlog until it is decided what the header should be.

gerritbot added a comment.Jul 13 2017, 12:45 PM

Change 364768 merged by jenkins-bot:
[mediawiki/extensions/WikibaseLexeme@master] Change Form's statements header text

https://gerrit.wikimedia.org/r/364768

• Aleksey_WMDE updated the task description. (Show Details)Jul 19 2017, 5:18 PM
• Aleksey_WMDE moved this task from Backlog to Done on the Wikidata-Former-Sprint-Board board.
Ladsgroup moved this task from incoming to in progress on the Wikidata board.Jul 20 2017, 9:27 AM
gerritbot added a comment.Jul 20 2017, 4:14 PM

Change 364690 abandoned by Aleksey Bekh-Ivanov (WMDE):
Rename title Forms to Morphology

Reason:
Decided not to rename for now

https://gerrit.wikimedia.org/r/364690

• Aleksey_WMDE closed this task as Resolved.Jul 25 2017, 10:22 AM
• Aleksey_WMDE claimed this task.
• Aleksey_WMDE moved this task from Done to Blocked External on the Wikidata-Former-Sprint-Board board.
Restricted Application added a subscriber: PokestarFan. · View Herald TranscriptJul 25 2017, 10:22 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits