Motivation
When choosing a file type in the interface, we offer a drop down that lists options. Currently this list does not include all possible file types (e.g. png is missing)
Task
Allow searching for all file types
Description
Description
Details
Details
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Create file type options dynamically | mediawiki/extensions/AdvancedSearch | master | +296 -131 |
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | kai.nissen | T170402 Allow searching for all existing filetypes | |||
| Resolved | Lea_WMDE | T176613 Show file sizes for images, vector graphics and videos |
Event Timeline
Comment Actions
Identified the bug that occurred when running AdvancedSearch tests with the latest mediawiki version. Apparently Qunit.test() does not support the expect amount as (optional) second parameter anymore, but wants it set via a dedicated method. https://gerrit.wikimedia.org/r/#/c/373106/ does the applicable changes.
Culprit, upgrade of qunit from 1.23.1 to v2.4.0 in T170515
However, this raises the question how reliable (with what versions and how they are managed) our CI is.
"mwext-qunit-jessie" on which AdvancedSearch qunit CI is run is still using karma-qunit@1.0.0 & qunitjs@1.23.1
Could not find any tickets addressing the question of bumping the CI version. Maybe @Addshore remembers how this can be done or whom to ask...
Comment Actions
https://github.com/wikimedia/mediawiki/blob/master/includes/libs/mime/MimeAnalyzer.php
MimeAnalyzer::getTypesForExtension() + MimeAnalyzer::guessTypesForExtension()
Comment Actions
Change 376706 had a related patch set uploaded (by Kai Nissen (WMDE); owner: Kai Nissen (WMDE)):
[mediawiki/extensions/AdvancedSearch@master] Create file type options dynamically
Comment Actions
Change 376706 merged by jenkins-bot:
[mediawiki/extensions/AdvancedSearch@master] Create file type options dynamically
Comment Actions
Hey @kai.nissen / @gabriel-wmde ,
have you had time to check what happens when a user would specify a height and width for an SVG file?
Comment Actions
Specifying a height/width for SVGs seems to work (at least in the sense as there are different results):
- https://commons.wikimedia.org/w/index.php?search=filemime%3Asvg+fileh%3A%3E1000&title=Special:Search&profile=default&fulltext=1
- https://commons.wikimedia.org/w/index.php?search=filemime%3Asvg&title=Special:Search&profile=default&fulltext=1
I've looked throuh the first 100 entries of SVGs and saw that they all have width/height.