| matmarex | |
| Jul 12 2017, 8:32 PM |
| F8722677: image.png | |
| Jul 12 2017, 8:32 PM |
| F8722698: image.png | |
| Jul 12 2017, 8:32 PM |
| F8722689: image.png | |
| Jul 12 2017, 8:32 PM |
We have inconsistent interface of "Select all / none / invert" buttons for lists of checkboxes.
The interface in all cases should look the same, and they all should use the same code.
Special:Search: (resources/src/mediawiki.special/mediawiki.special.search.js)
History: (ListToggle.php and resources/src/mediawiki/mediawiki.checkboxtoggle.js)
Special:Undelete: (resources/src/mediawiki.special/mediawiki.special.undelete.js)
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| checkboxtoggle: Unify "Select all/none/invert" across special pages | mediawiki/core | master | +39 -50 |
I don't care, and I don't think it really matters, since sooner or later someone will notice that these are not OOUI and redo them anyway ;)
@Aklapper thanks for responding.do we just need to change the button appearance in the above 3 files for the 3 cases ???
@vaibhavsingh: Hi! This task has been assigned to you a while ago. Could you maybe share an update? Do you still plan to work on this task, or do you need any help?
@vaibhavsingh: I am resetting the assignee of this task because there has not been progress lately (please correct me if I am wrong!). Resetting the assignee avoids the impression that somebody is already working on this task. It also allows others to potentially work towards fixing this task. Please claim this task again when you plan to work on it (via Add Action... → Assign / Claim in the dropdown menu) - it would be welcome. Thanks for your understanding!
Hi, I am Monica, a frontend developer interested in contributing to Wikimedia. I would like to work on this task as my first contribution. I will review the related files and propose a consistent UI implementation. Please let me know if there is a preferred interface pattern to follow.
Hello, I am a newcomer interested in contributing to MediaWiki and preparing for GSoC 2026.
I would like to work on this task if it is available. Please let me know if I can proceed.
Thank you.
Hi and welcome! Please see https://www.mediawiki.org/wiki/New_Developers#Communication_tips and the ticket status at the top below the title - thanks.
Hello, I would like to claim this task and start working on it.
I’m currently exploring the relevant codebase and understanding the issue. I’ll share updates as I make progress. Please let me know if there are any guidelines or suggestions I should follow before proceeding.
Thank you.
Change #1250526 had a related patch set uploaded (by Shreshth Srivastava; author: Shreshth Srivastava):
[mediawiki/core@master] checkboxtoggle: Unify "Select all/none/invert" across special pages
The patch unifies all three checkbox toggle implementations (Special:Search, Special:Undelete, and History/Log) to use the shared ListToggle component. Also fixes the global selector bug in checkboxtoggle.js (T131318) by scoping it per-container.
Took help from Claude for code review and implementation. Happy to address any feedback!