Page MenuHomePhabricator
Create Task
Maniphest T170597

Wikidata/extensions/Constraints: InvalidArgumentException:$itemId must be either ItemId or string
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Description

Seems to have started with the rollout of 1.30.0-wmf.9 to group1, is fairly noisy in error logs currently

#0 /srv/mediawiki/php-1.30.0-wmf.9/extensions/Wikidata/extensions/Constraints/includes/ConstraintCheck/Checker/TargetRequiredClaimChecker.php(139): WikibaseQuality\ConstraintReport\ConstraintParameterRenderer->formatItemId(Wikibase\DataModel\Entity\PropertyId)
#1 /srv/mediawiki/php-1.30.0-wmf.9/extensions/Wikidata/extensions/Constraints/includes/ConstraintCheck/DelegatingConstraintChecker.php(237): WikibaseQuality\ConstraintReport\ConstraintCheck\Checker\TargetRequiredClaimChecker->checkConstraint(Wikibase\DataModel\Statement\Statement, WikibaseQuality\ConstraintReport\Constraint, Wikibase\DataModel\Entity\Item)
#2 /srv/mediawiki/php-1.30.0-wmf.9/extensions/Wikidata/extensions/Constraints/includes/ConstraintCheck/DelegatingConstraintChecker.php(216): WikibaseQuality\ConstraintReport\ConstraintCheck\DelegatingConstraintChecker->getCheckResultFor(Wikibase\DataModel\Statement\Statement, WikibaseQuality\ConstraintReport\Constraint, Wikibase\DataModel\Entity\Item)
#3 /srv/mediawiki/php-1.30.0-wmf.9/extensions/Wikidata/extensions/Constraints/includes/ConstraintCheck/DelegatingConstraintChecker.php(181): WikibaseQuality\ConstraintReport\ConstraintCheck\DelegatingConstraintChecker->checkConstraintsForStatementOnEntity(array, Wikibase\DataModel\Entity\Item, Wikibase\DataModel\Statement\Statement)
#4 /srv/mediawiki/php-1.30.0-wmf.9/extensions/Wikidata/extensions/Constraints/includes/ConstraintCheck/DelegatingConstraintChecker.php(147): WikibaseQuality\ConstraintReport\ConstraintCheck\DelegatingConstraintChecker->checkStatement(Wikibase\DataModel\Entity\Item, Wikibase\DataModel\Statement\Statement, NULL)
#5 /srv/mediawiki/php-1.30.0-wmf.9/extensions/Wikidata/extensions/Constraints/includes/ConstraintCheck/DelegatingConstraintChecker.php(104): WikibaseQuality\ConstraintReport\ConstraintCheck\DelegatingConstraintChecker->checkEveryStatement(Wikibase\DataModel\Entity\Item, NULL)
#6 /srv/mediawiki/php-1.30.0-wmf.9/extensions/Wikidata/extensions/Constraints/api/CheckConstraints.php(191): WikibaseQuality\ConstraintReport\ConstraintCheck\DelegatingConstraintChecker->checkAgainstConstraintsOnEntityId(Wikibase\DataModel\Entity\ItemId, NULL)
#7 /srv/mediawiki/php-1.30.0-wmf.9/extensions/Wikidata/extensions/Constraints/api/CheckConstraints.php(179): WikibaseQuality\ConstraintReport\Api\CheckConstraints->checkItems(array, NULL)
#8 /srv/mediawiki/php-1.30.0-wmf.9/includes/api/ApiMain.php(1583): WikibaseQuality\ConstraintReport\Api\CheckConstraints->execute()
#9 /srv/mediawiki/php-1.30.0-wmf.9/includes/api/ApiMain.php(546): ApiMain->executeAction()
#10 /srv/mediawiki/php-1.30.0-wmf.9/includes/api/ApiMain.php(517): ApiMain->executeActionWithErrorHandling()
#11 /srv/mediawiki/php-1.30.0-wmf.9/api.php(94): ApiMain->execute()
#12 /srv/mediawiki/w/api.php(3): include(string)
#13 {main}

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Fix “Target required claim” error messagemediawiki/extensions/WikibaseQualityConstraintsmaster+1 -1
Customize query in gerrit

Related Objects

Event Timeline

thcipriani created this task.Jul 13 2017, 4:30 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 13 2017, 4:30 PM
thcipriani mentioned this in T170599: Wikibase: $idSerialization must match /^Q[1-9]\d{0,9}\z/i.Jul 13 2017, 4:36 PM
thcipriani added a parent task: T167893: MW-1.30.0-wmf.9 deployment blockers.
thcipriani triaged this task as Unbreak Now! priority.Jul 13 2017, 4:40 PM

UBN since I added as a train blocker.

Added as blocker as this appears to be a new log message with wmf.9.

Restricted Application added subscribers: Jay8g, TerraCodes. · View Herald TranscriptJul 13 2017, 4:40 PM
thcipriani lowered the priority of this task from Unbreak Now! to Medium.Jul 13 2017, 6:54 PM
thcipriani removed a parent task: T167893: MW-1.30.0-wmf.9 deployment blockers.

Removed as train blocker, seems to have been happening pre 1.30.0-wmf.9, sorry for the noise

Smalyshev added subscribers: LucasWerkmeister, Smalyshev.Jul 13 2017, 6:59 PM

This seems to be caused by TargetRequiredClaimChecker::checkConstraint passing PropertyId to ConstraintParameterRenderer::formatItemId where it only accepts ItemId. The problem here seems to be that data value is checked to be entity id, but entity id can be both property and item IDs.

Lucas_Werkmeister_WMDE subscribed.EditedJul 13 2017, 7:14 PM

Yeah, there are two “Target required claim” constraints on P​1647 (subproperty of), which has datatype property, but the code assumes its entity ID is an ItemId when formatting the violation message.

Lucas_Werkmeister_WMDE removed a subscriber: LucasWerkmeister.Jul 13 2017, 7:16 PM
gerritbot subscribed.Jul 13 2017, 7:20 PM

Change 365087 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/WikibaseQualityConstraints@master] Fix “Target required claim” error message

https://gerrit.wikimedia.org/r/365087

gerritbot added a project: Patch-For-Review.Jul 13 2017, 7:20 PM
Lucas_Werkmeister_WMDE added a comment.EditedJul 13 2017, 7:27 PM

The above change should fix this problem and apply cleanly on top of the currently deployed code (which is badaf32221 if I’m not mistaken).

gerritbot added a comment.Jul 14 2017, 7:48 AM

Change 365087 merged by jenkins-bot:
[mediawiki/extensions/WikibaseQualityConstraints@master] Fix “Target required claim” error message

https://gerrit.wikimedia.org/r/365087

Smalyshev assigned this task to Lucas_Werkmeister_WMDE.Jul 14 2017, 7:51 AM
thcipriani closed this task as Resolved.Jul 27 2017, 5:38 PM

I can't find any instance of this error message in logstash anymore. Thank you for your work on this!

Restricted Application added a subscriber: PokestarFan. · View Herald TranscriptJul 27 2017, 5:38 PM
• mmodell changed the subtype of this task from "Task" to "Production Error".Aug 28 2019, 11:10 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits